FieldDefinition -> ClassProperty?

[fisker]

babel / flow / @typecript-eslint/parser uses ClassProperty

I believe FieldDefinition is a old AST type from babel?

 require('meriyah').parse('class A{a=1}',{next:true}).body[0].body.body[0]
{ type: 'FieldDefinition',
  key: { type: 'Identifier', name: 'a' },
  value: { type: 'Literal', value: 1 },
  static: false,
  computed: false,
  decorators: [] }

[3cp]

Also PrivateName -> PrivateIdentifier

[3cp]

Latest is called PropertyDefinition, not ClassProperty?

https://github.com/estree/estree/blob/master/experimental/class-features.md

[3cp]

estree/estree#222

[fisker]

I didn't know that. I thought estree hasn't support class property.

I'm good with PropertyDefinition.

My purpose here is trying to align meriyah ast with other parsers, I think other parsers will change their asts, then no rush.

[3cp]

Maybe you can add support of old FieldDefinition for now? I will do a thorough cleanup in future to align with latest estree spec.

[KFlash]

@3cp I gave @fisker a "little upgrade" if he checks his email

[fisker]

Maybe you can add support of old FieldDefinition for now?

Already did.

[fisker]

@KFlash Thanks for you invitation, I may don't have time to contribute though 😄

[fisker]

Another difference between babel and meriyah

babel use PrivateName.id, meriyah use PrivateName.name.

We are going to follow the new spec anyway, so no need to change for now.

[3cp]

FYI, PrivateIdentifier.name is in latest spec. https://github.com/estree/estree/blob/master/experimental/class-features.md#privateidentifier