New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
context masks turns into negative value #193
Comments
As long as we only do bitwise operations around those options, it could be fine? |
https://github.com/meriyah/meriyah/search?q=OptionsUniqueKeyInPattern Looks fine to me. |
It looks okay, but I guess it's value is something like '-242585759" ? I didn't check it, but in some cases NodeJS / browser can end up mixing together multiple context masks when this is the only one you want to use. So suddenly you are in strict mode and disallow in context while parsing in module goal etc. |
I hope that you're right that the current code is fine. Shouldn't the following check use if ((context & Context.SuperCall) < 1) report(parser, Errors.SuperNoConstructor); |
It's possible to use bigint to store the option bits, it supports all bitwise operations. |
OptionsUniqueKeyInPattern = 1 << 31,
is a negative value and can cause conflicts and unexpected things can happen :)The text was updated successfully, but these errors were encountered: