Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erDiagram comments not rendering properly #2738

Closed
imaginedbyme opened this issue Feb 16, 2022 · 3 comments
Closed

erDiagram comments not rendering properly #2738

imaginedbyme opened this issue Feb 16, 2022 · 3 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@imaginedbyme
Copy link

Describe the bug
It looks like the comment column is rendering as the second column, overlapping the attribute name and whether it's a FK/PK etc. Happens on the documentation and on GitHub, but not on the live editor

I thought it was only happening on my local copy/on GitHub, but it's happening on the documentation as well (see here: https://mermaid-js.github.io/mermaid/#/entityRelationshipDiagram?id=attribute-keys-and-comments but not on the live editor https://mermaid.live/edit#pako:eNp1kU1OxDAMha9ihe30At2NaJEQUEYdxKob07jFIj8oSUGo07uTIRGIFryx8_wpek-eRW8liVKQqxhHh7ozEOty38LpVBR2hmZ_V1dF1V4_1i2UgErZd_9DzWk8lw-OzZgIkpXjN3JwdQOdeHgmUNyT8QR2gBCfmQL5hXVi842jkeOIga1pJv0UoTWi8YW2Ygykkrqkdqjb433zTx72v6BtnGTQ32b7h3Weiz-8D-x8aFBv3SlcL9gEwDELi9gJTU4jy3iUaOYsTK8SA9WSg3WiHFB52gmcgj1-mP5bSFS-YlaXT7RPlq0)

To Reproduce
Steps to reproduce the behavior:

  1. Write a comment on an erDiagram attribute

Expected behavior
The comment should appear as the final column.

Screenshots
Documentation:
image

Live Editor:
image

Code Sample
Live Editor link above

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version: 98.0.4758.102

Additional context
I couldn't find an open issue about this, so my apologies if there is one already

@imaginedbyme imaginedbyme added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Feb 16, 2022
@ockam
Copy link

ockam commented Feb 21, 2022

Don’t know if it’s the same bug, but my erDiagram fails with Error rendering markdown on Github if I use a comment column:

text some_field "Comment"

Works perfectly in VSCode preview (with Matt Biener Markdown Preview Mermaid Support plugin).

@RonaldZielaznicki
Copy link
Contributor

RonaldZielaznicki commented Mar 13, 2022

Likely a known issue #2346, #2548 that was fixed in 8.13.9, #2598.

I would guess that github is using a version earlier than 8.13.9

@Yash-Singh1
Copy link
Member

Closing as issue is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

4 participants