Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fontawesome example is broken in docs #3190

Closed
sidharthv96 opened this issue Jun 29, 2022 · 1 comment · Fixed by #3271
Closed

Fontawesome example is broken in docs #3190

sidharthv96 opened this issue Jun 29, 2022 · 1 comment · Fixed by #3271
Labels
Area: Documentation Good first issue! Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Describe the bug
No icons are rendered in FA example in docs

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://mermaid-js.github.io/mermaid/#/flowchart?id=basic-support-for-fontawesome

Expected behavior
FA icon is rendered

Screenshots
image
@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc Area: Documentation Good first issue! and removed Status: Triage Needs to be verified, categorized, etc labels Jun 29, 2022
@heyfirst heyfirst mentioned this issue Jul 31, 2022
Merged
3 tasks
@heyfirst
Copy link
Contributor

heyfirst commented Jul 31, 2022 •
edited

Hey @sidharthv96 @knsv, I have opened #3271, Would you care to review the PR?

@knsv knsv closed this as completed in #3271 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Documentation Good first issue! Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add font-awesome css to docsify index.html heyfirst/mermaid
2 participants
@heyfirst @sidharthv96