Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to suggest pre instead of div in HTML? #3407

Closed
sidharthv96 opened this issue Sep 4, 2022 · 0 comments · Fixed by #3408
Closed

Update docs to suggest pre instead of div in HTML? #3407

sidharthv96 opened this issue Sep 4, 2022 · 0 comments · Fixed by #3408
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Describe the bug
Prettier formats div breaking mermaid text when using div.

Before:
image
image

After formatting:
image
image

To Reproduce
Steps to reproduce the behavior:

  1. Run prettier on any HTML containing mermaid code.

Expected behavior
Diagram is rendered after formatting.
@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Sep 4, 2022
sidharthv96 added a commit that referenced this issue Sep 4, 2022
@sidharthv96
fix #3407 Replace div with pre and format

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
GPG key ID: B1EA99A6C5178449
Verified
Learn about vigilant mode
91478ca
@sidharthv96 sidharthv96 mentioned this issue Sep 4, 2022
Merged
3 tasks
@knsv knsv closed this as completed in #3408 Sep 5, 2022
knsv added a commit that referenced this issue Sep 5, 2022
@knsv
Merge pull request #3408 from mermaid-js/sidv/preTags

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
GPG key ID: B1EA99A6C5178449
Verified
Learn about vigilant mode
afd1b6e 
fix #3407 Replace `div` with `pre` and format
sidharthv96 added a commit that referenced this issue Sep 5, 2022
@sidharthv96
Merge branch 'develop' into sidv/docs

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
GPG key ID: B1EA99A6C5178449
Verified
Learn about vigilant mode
5e9db25 
* develop:
  chore: update browsers list
  Fix pre
  Prettier pass
  Fix XSS htmls
  fix #3407 Replace `div` with `pre` and format
sidharthv96 added a commit that referenced this issue Sep 5, 2022
@sidharthv96
Merge branch 'develop' into sidv/typescript

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
GPG key ID: B1EA99A6C5178449
Verified
Learn about vigilant mode
d898b8a 
* develop: (50 commits)
  Build docs
  chore: update browsers list
  Fix pre
  Fix mermaid code formatting in html
  Prettier pass
  Fix XSS htmls
  fix #3407 Replace `div` with `pre` and format
  Add change in `src/docs`
  Fix lint issue
  build: run `build:prod` on `yarn prepare`
  Build documentation
  Fix typo
  Fix typo in documentation
  Fix doc
  Add files only when running from lint-staged
  Add files only when running from lint-staged
  Fix configuration doc
  Prettier Pass
  Add dotfiles
  Prettier
  ...
sidharthv96 added a commit that referenced this issue Sep 5, 2022
@sidharthv96
Merge branch 'develop' into sidv/esbuild

Verified

This commit was signed with the committer’s verified signature.
KinectTheUnknown David-Joseph Xayavong
GPG key ID: B1EA99A6C5178449
Verified
Learn about vigilant mode
f9bf535 
* develop: (50 commits)
  Build docs
  chore: update browsers list
  Fix pre
  Fix mermaid code formatting in html
  Prettier pass
  Fix XSS htmls
  fix #3407 Replace `div` with `pre` and format
  Add change in `src/docs`
  Fix lint issue
  build: run `build:prod` on `yarn prepare`
  Build documentation
  Fix typo
  Fix typo in documentation
  Fix doc
  Add files only when running from lint-staged
  Add files only when running from lint-staged
  Fix configuration doc
  Prettier Pass
  Add dotfiles
  Prettier
  ...
@Avishri99 Avishri99 mentioned this issue Oct 10, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
1 participant
@sidharthv96