Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Updates #3581

Closed
Aniket1026 opened this issue Oct 5, 2022 · 7 comments
Closed

Readme Updates #3581

Aniket1026 opened this issue Oct 5, 2022 · 7 comments
Assignees
Labels
Status: Triage Needs to be verified, categorized, etc Type: Other Not an enhancement or a bug

Comments

@Aniket1026
Copy link
Contributor

In the contribution guidelines documentation . As for some beginners can we add some more steps that may help them setting the project locally on their system ? I'm attaching a screenshort regarding adding some documentation updates.

mermaid js readme

If it looks helping you can assign me . So i can raise a PR

Also in the contributing.md it is stated that Documentation source files are in /src/docs directory . I'm just not able to find that directory too . My doubt here is did the directory name needs to update or am i making a mistake regarding the path directory.

mermaid js

@Aniket1026 Aniket1026 added the Type: Other Not an enhancement or a bug label Oct 5, 2022
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Oct 5, 2022
@sidharthv96
Copy link
Member

/src/docs directory has moved to packages/mermaid/src/docs.

@Aniket1026
Copy link
Contributor Author

Created the PR for the Steps i added.

But what for the updated path ? Should i also change the path in the documentation from /src/docs to packages/mermaid/src/docs ?

@sidharthv96
Copy link
Member

You can update the path

@Aniket1026
Copy link
Contributor Author

@sidharthv96 can I raise another issue for automating the linting as you mentioned earlier?

@weedySeaDragon
Copy link
Contributor

@Aniket1026 - I just submitted PR #3814 that revises the instructions for contributing/developing.
Can you please review it? I'd love your feedback.

Hopefully I can incorporate your feedback and address your issue with it.

@Aniket1026
Copy link
Contributor Author

@weedySeaDragon I apologize for replying so late as I was just busy in other things . And for the review you asked for it's upto maintainers what they want in the project but personally i liked how you described your changes while raising the issue.
keep it up and contribute to open source projects 😄 .

@jgreywolf
Copy link
Contributor

Closing this issue as it should be addressed when PR #3814 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Other Not an enhancement or a bug
Projects
None yet
Development

No branches or pull requests

4 participants