Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misplaced labels #3882

Closed
knsv opened this issue Dec 3, 2022 · 0 comments · Fixed by #3883
Closed

Misplaced labels #3882

knsv opened this issue Dec 3, 2022 · 0 comments · Fixed by #3883
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented Dec 3, 2022 •
edited

Description

In some cases where you have an edge to a cluster the label ands up in the wrong place.

Steps to reproduce

flowchart LR
    A --L--> Sub
    B --> A
    subgraph Sub
        C
        B
    end

Screenshots

image

Code Sample

No response

Setup

Desktop

  • OS and Version: [Windows, Linux, Mac, ...]
  • Browser and Version: [Chrome, Edge, Firefox]

Smartphone

  • Device: [Samsung, iPhone, ...]
  • OS and Version: [Android, iOS, ...]
  • Browser and Version: [Chrome, Safari, ...]

Additional Context

No response
@knsv knsv added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Dec 3, 2022
knsv added a commit that referenced this issue Dec 3, 2022
@knsv
Fix for issue #3882 moving the label when the path has been modified
4124d18
@knsv knsv mentioned this issue Dec 3, 2022
Merged
3 tasks
rhirano0715 pushed a commit to rhirano0715/mermaid that referenced this issue Dec 4, 2022
@sidharthv96
Merge branch 'develop' into sidv/mermaidDocs
ab81b50 
* develop: (79 commits)
  chore: docs:build
  chore: docs:build
  tiny fix and change: "The/y cannot" -> "Cannot..."
  remove 'horz' from  cSpell.json
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove 'horz' from  cSpell.json
  Revert "Added pie"
  chore: Fix cSpell in pieRenderer
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove console stmt
  mermaid-js#3831 Re-enabling themes for er diagrams
  mermaid-js#3835 Adding path to list of elements to be styled
  mermaid-js#3882 fix for issues with mindmaps  with only a single node
  chore(deps): update pnpm to v7.17.0
  docs: Remove warning in readme
  chore(deps): update lycheeverse/lychee-action action to v1.5.4
  ...
@knsv knsv closed this as completed in #3883 Dec 5, 2022
Nlicroshan pushed a commit to Nlicroshan/mermaid that referenced this issue Dec 5, 2022
@knsv
mermaid-js#3882 fix for issues with mindmaps with only a single node
564414e
Nlicroshan pushed a commit to Nlicroshan/mermaid that referenced this issue Dec 5, 2022
@pbrolin47
Merge pull request mermaid-js#3833 from mermaid-js/3832_mindmaps_sing…
32db430 
…le_node

mermaid-js#3882 fix for issues with mindmaps  with only a single node
Nlicroshan pushed a commit to Nlicroshan/mermaid that referenced this issue Dec 5, 2022
@sidharthv96
Merge branch 'develop' into sidv/optimizeSize
9da29da 
* develop: (21 commits)
  chore: docs:build
  chore: docs:build
  tiny fix and change: "The/y cannot" -> "Cannot..."
  remove 'horz' from  cSpell.json
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove 'horz' from  cSpell.json
  Revert "Added pie"
  chore: Fix cSpell in pieRenderer
  update demos/state.html to includ examples; formatting
  add 'horz' to cSpell (in pieDetector.ts commented out barChart work)
  refine - what is not done yet
  remove console stmt
  mermaid-js#3831 Re-enabling themes for er diagrams
  mermaid-js#3835 Adding path to list of elements to be styled
  mermaid-js#3882 fix for issues with mindmaps  with only a single node
  Integrations added - Visual Studio Code [Polyglot Interactive Notebooks]
  Fix typos
  mermaid-js#3778 Adding a hexgon shape
  ...
sidharthv96 added a commit that referenced this issue Dec 7, 2022
@sidharthv96
Merge remote-tracking branch 'origin/develop' into sidv/autoBuildDocs
963a1f1 
* origin/develop: (564 commits)
  chore: Format Mermaid.vue
  Made mermaidConfig a local variable so that it cannot be shared cross rendering.
  Fix for issue #3882 moving the label when the path has been modified
  Small fix for issue #3881
  Fixed an issue that diagrams disappear from docs pages when switching themes or reloading pages
  Fixed the issue that theme-switch does not work on docs.
  chore: Fix mindmap link
  chore: Switch back from unpkg to jsdelivr
  delete functions not used in diagrams/c4 code (dead code)
  Minor change
  feat: Add @include support to docs
  feat: Add @include example to docs
  feat: Add @include support to docs
  cleanup
  fix lines
  fix Async rendering
  Revert "sync"
  chore(deps): update pnpm to v7.17.1
  chore(deps): remove dependency on `graphlib`
  test(e2e): make gitgraph snapshots consistent
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3882 edge labels mermaid-js/mermaid
1 participant
@knsv