Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update latest news #4959

Merged
merged 4 commits into from Nov 7, 2023
Merged

Docs: update latest news #4959

merged 4 commits into from Nov 7, 2023

Conversation

huynhicode
Copy link
Member

@huynhicode huynhicode commented Oct 19, 2023

📑 Summary

This PR contains updates to the Latest News section:

  • Announcements: remove Product Hunt content and add latest blog posts
  • Blog: add latest blog posts

Resolves # n/a

📏 Design Decisions

Design decisions made by the Mermaid Chart team.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c117447
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6549fb608594a400074148e4
😎 Deploy Preview https://deploy-preview-4959--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huynhicode huynhicode changed the base branch from develop to master October 19, 2023 18:39
@huynhicode huynhicode marked this pull request as ready for review October 19, 2023 18:40
@huynhicode huynhicode requested a review from knsv October 19, 2023 18:40
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #4959 (c117447) into master (d1045ed) will decrease coverage by 2.75%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   78.08%   75.34%   -2.75%     
==========================================
  Files         164      164              
  Lines       13820    13820              
  Branches      693      693              
==========================================
- Hits        10792    10412     -380     
- Misses       2876     3238     +362     
- Partials      152      170      +18     
Flag Coverage Δ
e2e 80.18% <ø> (-3.43%) ⬇️
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

In the long run, it might be nice to automatically generate these. It sounds like Vitepress can do this, see https://vitepress.dev/guide/what-is-vitepress#use-cases.

Although, if we only update the latest news every couple of weeks, it's potentially easier to just keep manually updating everything.

@aloisklink aloisklink merged commit 4ecf780 into master Nov 7, 2023
23 of 24 checks passed
@aloisklink aloisklink deleted the update-latest-news branch November 7, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants