Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #4979

Merged
merged 2 commits into from Oct 31, 2023
Merged

Update README.md #4979

merged 2 commits into from Oct 31, 2023

Conversation

karthxk07
Copy link
Contributor

@karthxk07 karthxk07 commented Oct 23, 2023

📑 Summary

Updated the Readme.md file to change a typo

Resolves #4978

📏 Design Decisions

In the sentence "Tutorials has video tutorials," it should be "Tutorials have video tutorials" for subject-verb agreement.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit ff4d68f
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6538d4ca88cadb00088f9b1f
😎 Deploy Preview https://deploy-preview-4979--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4979 (ff4d68f) into develop (3957575) will decrease coverage by 0.77%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4979      +/-   ##
===========================================
- Coverage    80.13%   79.37%   -0.77%     
===========================================
  Files          164      164              
  Lines        13815    13815              
  Branches       693      693              
===========================================
- Hits         11071    10966     -105     
- Misses        2594     2700     +106     
+ Partials       150      149       -1     
Flag Coverage Δ
e2e 85.23% <ø> (-0.96%) ⬇️
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@huynhicode
Copy link
Member

@karthxk07 Thanks for your PR!

I think in the context of the docs, using "has" makes more sense than using "have" since docs has an it pronoun.

Maybe you can update the verbiage to something like, "For video tutorials, visit our Tutorials page."

Screenshot 2023-10-24 at 3 59 42 PM

@huynhicode huynhicode self-requested a review October 24, 2023 23:07
Copy link
Member

@huynhicode huynhicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@karthxk07
Copy link
Contributor Author

@huynhicode Yup, that sounds better , I will make the change right away.

@sidharthv96 sidharthv96 added this pull request to the merge queue Oct 31, 2023
Merged via the queue into mermaid-js:develop with commit 34f1db3 Oct 31, 2023
17 checks passed
@mermaid-bot
Copy link

mermaid-bot bot commented Oct 31, 2023

@karthxk07, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[typo] "Tutorials has video tutorials," should be "Tutorials have video tutorials" in the Readme.md
3 participants