Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update Latest News section #5107

Merged
merged 1 commit into from Dec 4, 2023
Merged

Docs: update Latest News section #5107

merged 1 commit into from Dec 4, 2023

Conversation

huynhicode
Copy link
Member

📑 Summary

This PR contains updates to the Latest News section:

  • Announcements page: add latest blog post & minor verbiage update
  • Blog page: add latest blog post

Resolves # n/a

📏 Design Decisions

Design decisions come from within the Mermaid Chart team.

📋 Tasks

Make sure you

Screenshots:

Screenshot 2023-12-04 at 11 10 11 AM Screenshot 2023-12-04 at 11 11 11 AM

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 78c44bf
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/656e24a09e57210009d7bc08
😎 Deploy Preview https://deploy-preview-5107--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The failing status on the link checker CI is unrelated: https://github.com/mermaid-js/mermaid/actions/runs/7091400128/job/19300455455?pr=5107. It looks like errors with https://bundlephobia.com/package/mermaid and https://nicegui.io/reference

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #5107 (78c44bf) into master (a1563c9) will decrease coverage by 36.85%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5107       +/-   ##
===========================================
- Coverage   79.78%   42.94%   -36.85%     
===========================================
  Files         164       23      -141     
  Lines       13820     4972     -8848     
  Branches      693       21      -672     
===========================================
- Hits        11026     2135     -8891     
- Misses       2644     2836      +192     
+ Partials      150        1      -149     
Flag Coverage Δ
e2e ?
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 160 files with indirect coverage changes

@aloisklink aloisklink merged commit 542fc19 into master Dec 4, 2023
24 of 25 checks passed
@aloisklink aloisklink deleted the add-blog branch December 4, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants