Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new extension to integrations #5287

Merged

Conversation

BoDonkey
Copy link
Contributor

@BoDonkey BoDonkey commented Feb 15, 2024

📑 Summary

Brief description about the content of your PR.
This PR updates the integrations list in the documentation to include a new extensionfor adding Mermaid.js diagrams to ApostropheCMS, an open-source CMS.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit eaffe33
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65cf38dfc57bf50008621f25
😎 Deploy Preview https://deploy-preview-5287--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BoDonkey BoDonkey marked this pull request as draft February 15, 2024 19:23
@BoDonkey BoDonkey marked this pull request as ready for review February 15, 2024 19:25
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe1cff3) 79.14% compared to head (eaffe33) 79.15%.
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5287   +/-   ##
========================================
  Coverage    79.14%   79.15%           
========================================
  Files          175      175           
  Lines        14512    14514    +2     
  Branches       866      866           
========================================
+ Hits         11486    11488    +2     
  Misses        2823     2823           
  Partials       203      203           
Flag Coverage Δ
e2e 84.72% <ø> (+<0.01%) ⬆️
unit 43.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@huynhicode huynhicode self-requested a review February 16, 2024 04:05
Copy link
Member

@huynhicode huynhicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@sidharthv96 sidharthv96 added this pull request to the merge queue Feb 19, 2024
Merged via the queue into mermaid-js:develop with commit 70c8a3d Feb 19, 2024
20 checks passed
Copy link

mermaid-bot bot commented Feb 19, 2024

@BoDonkey, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@BoDonkey BoDonkey deleted the docs/add-apostrophecms-integration branch February 19, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants