Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace version number placeholder #5304

Merged

Conversation

BaumiCoder
Copy link
Contributor

The header of the section contains the version number for the feature, so the warning box should contain the same version

📑 Summary

In own section of the documentation the MERMAID_RELEASE_VERSION was used literally at one place. May it was an misunderstand or a slip in 4efac67.

📏 Design Decisions

The MERMAID_RELEASE_VERSION is not suitable here. If I understand correctly a <MERMAID_RELEASE_VERSION> in the markdown would be replaced with the current version of mermaid (e.g., in the Contributing page), but a specific feature is introduced in a specific version. So a dynamic version number is not suitable here.

📋 Tasks

Make sure you

The header of the section contains the version number for the feature,
so the warning box should contain the same version
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 81491f2
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65d4f07c31c0580008715be7

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70c8a3d) 43.20% compared to head (81491f2) 79.15%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5304       +/-   ##
============================================
+ Coverage    43.20%   79.15%   +35.94%     
============================================
  Files           23      175      +152     
  Lines         5115    14514     +9399     
  Branches        23      866      +843     
============================================
+ Hits          2210    11488     +9278     
+ Misses        2904     2823       -81     
- Partials         1      203      +202     
Flag Coverage Δ
e2e 84.72% <ø> (?)
unit 43.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

@sidharthv96 sidharthv96 merged commit a4ba282 into mermaid-js:develop Feb 26, 2024
15 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants