Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to read records from a resource without connection options #107

Open
hariso opened this issue Oct 14, 2022 · 0 comments
Open

Option to read records from a resource without connection options #107

hariso opened this issue Oct 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@hariso
Copy link
Contributor

hariso commented Oct 14, 2022

We have two ways to write records: with or without ConnectionOptions/ResourceConfigs (going to be renamed in #105).

Write(records Records, collection string) error
WriteWithConfig(records Records, collection string, cfg ResourceConfigs) error

However, there's only one "flavor" of Records (used for reads), which is without ConnectionOptions/ResourceConfigs:

Records(collection string, cfg ResourceConfigs) (Records, error)

If there are use cases for reading records using the default properties, i.e. without using ConnectionOptions/ResourceConfigs, then we should have that method too. That would make the methods in Resource more consistent too.

@hariso hariso added the enhancement New feature or request label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant