Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Lighthouse score of Meshery.io #973

Open
Udit-takkar opened this issue Jan 15, 2023 · 22 comments
Open

Low Lighthouse score of Meshery.io #973

Udit-takkar opened this issue Jan 15, 2023 · 22 comments
Labels
issue/willfix This issue will be worked on kind/bug Something isn't working kind/epic An issue that describes a set of concerns (issues)

Comments

@Udit-takkar
Copy link

Description

meshery.io is failing the Core Web Vitals Assessment

Mobile performance score is between 20-40

Check here:- https://pagespeed.web.dev/report?url=https%3A%2F%2Fmeshery.io%2F&form_factor=mobile

Expected Behavior

The landing page should pass the Core Web Vitals Assessment

Screenshots

Screenshot 2023-01-15 at 9 32 57 PM

Enviroment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

@Udit-takkar Udit-takkar added the kind/bug Something isn't working label Jan 15, 2023
@welcome
Copy link

welcome bot commented Jan 15, 2023

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Meshery Contributors' Welcome Guide and sure to join the community Slack.

@Udit-takkar Udit-takkar added the kind/epic An issue that describes a set of concerns (issues) label Jan 15, 2023
@Udit-takkar Udit-takkar self-assigned this Jan 15, 2023
@Yashsharma1911
Copy link
Contributor

Hey @Udit-takkar, do you have any suggestions on how we can improve it

@Udit-takkar
Copy link
Author

@Yashsharma1911 will have to test a lot of things with lighthouse report and use some concepts learned from here layer5io/layer5#3572 (comment). Some things like lazy loading below the fold images, using images of webp quality, properly loading the third party code, preloading fonts ... etc.

@Yashsharma1911
Copy link
Contributor

Hey, @Udit-takkar are you still working on this?

@Udit-takkar
Copy link
Author

Udit-takkar commented Feb 7, 2023

@Yashsharma1911 yeah will start after 17 when my exams end

@stale
Copy link

stale bot commented Mar 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 10, 2023
@Udit-takkar Udit-takkar removed the issue/stale Issue has not had any activity for an extended period of time label Mar 10, 2023
@stale
Copy link

stale bot commented Apr 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 9, 2023
@Udit-takkar Udit-takkar removed the issue/stale Issue has not had any activity for an extended period of time label Apr 9, 2023
@saisuvanth
Copy link

Hey @Yashsharma1911 , I have some ideas on how to make it better by reducing render blocking time. Can I work on this issue?

@Udit-takkar
Copy link
Author

@saisuvanth yeah go ahead

@stale
Copy link

stale bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 8, 2023
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Jun 12, 2023
@stale
Copy link

stale bot commented Jul 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 12, 2023
@thisiskaransgit thisiskaransgit added the issue/willfix This issue will be worked on label Jul 13, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 13, 2023
@iArchitSharma
Copy link
Contributor

@Udit-takkar are you still working on this issue?

@iArchitSharma
Copy link
Contributor

Reanalyzed the assessments; improvements have been made.
image

@Savio629
Copy link
Contributor

Is it possible to increase the performance more?
@iArchitSharma

@iArchitSharma
Copy link
Contributor

@Savio629, yes, it can be, check the recommendations in the Opportunities section of the results

@Akshun-01
Copy link
Contributor

Hello, I would like to give this one a try!

@Yashsharma1911
Copy link
Contributor

Please go ahead, also try sharing your progress as you go so that others can help you if needed ^^

@Akshun-01
Copy link
Contributor

Hey, Just dropping the update on this.

Changed the .gif files to .webp format.

( I tried webm and mpeg4 as it suggested but they were not working so I used webp instead)

This is the before and after change :

Before

image

After (best practice is low because of using local host instead of https)

image

Should I start a draft PR, or make a PR after making considerable changes? @Yashsharma1911

@Yashsharma1911
Copy link
Contributor

Hey this is good 👏, yes please raise a draft PR so that others can provide a review as you go.

@tayyab-ilyas
Copy link

Hi does this issue still needs to be addressed ? I ran a lighthouse test and the performance metric is currently at 53. I'd like to give this a go and target to touch 80-ish.

@Yashsharma1911
Copy link
Contributor

Yashsharma1911 commented May 1, 2024

Hey yes this is still an area for help, and target sounds good too, you can work on it, also as you go and explore ways to increase lighthouse score I'll suggest to create draft PR so that maintainers can provide you feedback along the way

@tayyab-ilyas
Copy link

Hi @Yashsharma1911 I tried a bunch of stuff like deferring scripts, preloading CSS, and even tested out WebP format for assets but still no significant improvements in performance. I'll try to work on some other issue now. I hope that I didn't waste your time here. thanks!

@tayyab-ilyas tayyab-ilyas removed their assignment May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on kind/bug Something isn't working kind/epic An issue that describes a set of concerns (issues)
Projects
None yet
9 participants