[CI] Move to latest version of golangci-lint

[nishantwrp]

Move to the latest version of golangci-lint after golangci/golangci-lint-action#535 is fixed. #5991 rollbacks the version of golangci-lint due to the given bug.

---

Contributor Guides and Handbook

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

[alphaX86]

@nishantwrp is this completed? If so, can we safely close this issue?

[nishantwrp]

Hi @alphaX86, no it's not. We need to start using latest version of golangci-lint again, which will only be possible after golangci/golangci-lint-action#535 is fixed.

[alphaX86]

Ok understood. Thanks for clearing this

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

---

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

[nishantwrp]

golangci/golangci-lint-action#535 is still not fixed. We can only work on this after the issue in golangci-lint gets fixed.

[acald-creator]

I will be working optimizing the GitHub Actions workflows.

There are several different workflows, and one of the suggestion is to create a separate workflow specifically for golangci-lint so that when it comes to reviewing PRs, we can work faster on the PR specific to ui or anything else that is not Go.

[leecalcote]

Hopefully, we'll get a bird's eye view assembled in the Meshery Test Plan spreadsheet with an overview of the workflows included.

[segunjkf]

can i work on this?

[leecalcote]

@segunjkf that'd be great, yes.

[segunjkf]

@leecalcote Golangci-lint, in my opinion, should have its own link workflow. I looked around and discovered it in the build-ui-and-server.yaml workflow.

[nishantwrp]

Hi, I'm not sure if this issue can be fixed until golangci/golangci-lint-action#535 is fixed.

[acald-creator]

I already have a branch working on the golangci-lint GitHub Actions workflow as well as trying out the different linting settings. I will submit a PR today.

As for the open issue, I haven't encountered this with Go 1.19, since we're not using Go 1.18

[acald-creator]

For your reference, here is my branch in progress. The only reason why I haven't submitted the PR yet because of the linting settings which will cause the workflow to instantly fail.

master...acald-creator:meshery:enhance-golangci-lint

I am also working on a separate branch as well with just the workflow.