Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to React 0.14 #2710

Closed
pierluigi opened this issue Nov 24, 2015 · 7 comments
Closed

Migrate to React 0.14 #2710

pierluigi opened this issue Nov 24, 2015 · 7 comments

Comments

@pierluigi
Copy link

Let's migrate to the latest React version and keep our codebase maintainable.

@aldipower
Copy link
Contributor

Currently we have a well working UI in terms of the architecture.

Some questions:

Where do you see non-maintainability arising?
Where are the advantages/enablers of the new React version?
Where are the pitfalls?

@pierluigi
Copy link
Author

Yes, let's approach this pragmatically. Moving to React 0.14 would give us:

  • being able to leverage all the latest React Router goodness: dynamic routes, much nicer Route syntax, embedded router properties in components, and more
  • removing React.findDOMNode() calls (refs now return the DOM node)
  • a really yummy shallowCompare addon: Add shallowCompare module and use it in PureRenderMixin + tests facebook/react#3355
  • allow us to use the latest onClickOutsideMixin with my PR that fixes server-side rendering for components that make use of it
  • support for testing components with <Link /> elements via ReactRouter >= 1.0

All in all not that much goodness within React 0.14 per se, and I agree these things shouldn't have the highest priority.

@pierluigi
Copy link
Author

@aldipower @philipnrmn @orlandohohmeier backlogging this issue for the moment. Correct me as you see fit!

@pierluigi pierluigi added this to the Backlog milestone Dec 2, 2015
@orlandohohmeier
Copy link
Contributor

@pierlo-upitup Ok, but we shouldn't put this on the shelf. I agree that updating to a new react version doesn't have the highest priority and comes with some risk, but it becomes more risky/painful the longer we wait... Let's schedule the update for the next few months.

@pierluigi
Copy link
Author

@orlandohohmeier that's what Backlog is for 😉

@orlandohohmeier
Copy link
Contributor

@pierlo-upitup Yeah, but it feels like some of the issue were sitting in the backlog for quite a while and I think we should revisit this one soon (maybe within the next two release).

@meichstedt
Copy link
Contributor

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3047. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants