Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Setup flow for static/public embedding & embedding feature discoverability #35961

Closed
20 tasks done
oisincoveney opened this issue Nov 20, 2023 · 1 comment
Closed
20 tasks done

[Epic] Setup flow for static/public embedding & embedding feature discoverability #35961

oisincoveney opened this issue Nov 20, 2023 · 1 comment
Assignees
@deniskaber @oisincoveney
Labels
.Epic Feature Implementation or Project .Team/Embedding
Milestone
0.49

Comments

@oisincoveney
Copy link
Contributor

oisincoveney commented Nov 20, 2023 •
edited by NevRA

Links

✅ Milestone 1: Share/Embed Popover

Author: @oisincoveney

Tasks
Beta Give feedback
  1. Add popover/embed modal display logic to the dashboard embed button #35999
    .Team/Embedding no-backport
    oisincoveney
  2. Add public link creation user flow #36107
    .Team/Embedding
    oisincoveney
  3. Milestone 1 Refactor #36789
    .Team/Embedding
    oisincoveney
  4. [Epic #35961] Milestone 1 - Refactor Public Links and Static Embed Flow #36048
    .Team/Embedding no-backport
    oisincoveney

Milestone 2: Create the embed modal

Author: @oisincoveney

Tasks
Beta Give feedback
  1. Add embedding types to Dashboards and Cards #36521
    .Team/Embedding
    oisincoveney
  2. [#35961 M2] Split Link Panel from Popover #36527
    .Team/Embedding
    oisincoveney
  3. [#35961 M2] Change modal size based on embed step #36530
    .Team/Embedding
    oisincoveney
  4. [#35961 M2] Add setup modal #36519
    .Team/Embedding
    oisincoveney
  5. [#35961 M2] Modify E2E Tests to match new Embed Setup Modal #36634
    .Team/Embedding
    oisincoveney
  6. [Epic #35961] Milestone 2 - Create the Embed Modal #36170
    .Team/Embedding no-backport
    oisincoveney

Milestone 3: Interactive Embedding CTA

Author: @oisincoveney

Tasks
Beta Give feedback
  1. [Epic #35961] Milestone 3 - Add Interactive Embedding CTA to Embed Modal #36890
    no-backport
    oisincoveney

Milestone 4: Add Legalese Step

Tasks
Beta Give feedback
  1. [#35961 M4] Add legalese step without any checks #37008
    .Team/Embedding
    oisincoveney
  2. [#35961 M4] Add backend verification for accepting embedding legalese #37327
    .Team/Embedding
    oisincoveney
  3. [Epic #35961] Milestone 4 - Add Legalese Step #37006
    .Team/Embedding no-backport
    oisincoveney

Milestone 5: Split the embedding options into three tabs

Author: @deniskaber

Tasks
Beta Give feedback
  1. Static Embedding Modal redesign #36181
    .Team/Embedding no-backport visual
    deniskaber
  2. Add SegmentedToggle component from mantine #37007
    .Team/Embedding no-backport
    deniskaber
  3. Add code diff logic and switch to preview mode #37155
    .Team/Embedding no-backport
    deniskaber

Milestone 6: Miscellaneous Improvements

Tasks
Beta Give feedback
  1. Modify Embedded Analytics UTM codes #37614
    .Team/Embedding no-backport
    oisincoveney
  2. Add snowplow events for embedding setup flow #37617
    .Team/Embedding no-backport visual
    oisincoveney
  3. Keeps preview across different tabs #38271
    .Team/Embedding no-backport
    WiNloSt
@oisincoveney oisincoveney added the .Epic Feature Implementation or Project label Nov 20, 2023
@oisincoveney oisincoveney mentioned this issue Nov 21, 2023
Merged
1 task
This was referenced Nov 22, 2023
Closed
Merged
@WiNloSt
Copy link
Member

WiNloSt commented Nov 23, 2023

@oisincoveney I encountered a problem where hitting the Esc key doesn't fully close the modal. This doesn't happen on master @ 626d240

https://www.loom.com/share/d6e06444eb1c4bf29d84e5a49f329479

@albertoperdomo albertoperdomo mentioned this issue Nov 24, 2023
Closed
@oisincoveney oisincoveney mentioned this issue Nov 28, 2023
Merged
This was referenced Nov 28, 2023
Merged
Merged
Merged
@oisincoveney oisincoveney mentioned this issue Nov 30, 2023
Merged
1 task
@oisincoveney oisincoveney self-assigned this Dec 6, 2023
This was referenced Dec 7, 2023
Merged
Merged
Merged
This was referenced Dec 12, 2023
Merged
Merged
oisincoveney added a commit that referenced this issue Dec 12, 2023
@oisincoveney
[#35961 M2] Split Link Panel from Popover (#36527)
457867f
oisincoveney added a commit that referenced this issue Dec 14, 2023
@oisincoveney @WiNloSt
[#35961 M2] Change modal size based on embed step (#36530)
6a9f315 
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
@oisincoveney oisincoveney mentioned this issue Dec 15, 2023
Merged
1 task
oisincoveney added a commit that referenced this issue Dec 15, 2023
@oisincoveney @WiNloSt
[#35961 M2] Add setup modal (#36519)
555601a 
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
oisincoveney added a commit that referenced this issue Dec 15, 2023
@oisincoveney @WiNloSt
[#35961 M2] Add setup modal (#36519)
d3b7943 
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
@oisincoveney oisincoveney mentioned this issue Dec 18, 2023
Merged
1 task
oisincoveney added a commit that referenced this issue Dec 18, 2023
@oisincoveney
[#35961 M2] Modify E2E Tests to match new Embed Setup Modal (#36634)
603a7c1
oisincoveney added a commit that referenced this issue Dec 19, 2023
@oisincoveney
Initialize Milestone 4 of #35961
500635d
oisincoveney added a commit that referenced this issue Dec 20, 2023
@oisincoveney @WiNloSt
[Epic #35961] Milestone 1 - Refactor Public Links and Static Embed Fl…
02fa2c9 
…ow (#36048)

Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
oisincoveney added a commit that referenced this issue Dec 20, 2023
@oisincoveney @WiNloSt
[Epic #35961] Milestone 2 - Create the Embed Modal (#36170)
4658e28 
Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
@deniskaber deniskaber mentioned this issue Dec 20, 2023
Merged
1 task
@deniskaber deniskaber mentioned this issue Dec 28, 2023
Merged
1 task
This was referenced Jan 4, 2024
Merged
Merged
oisincoveney added a commit that referenced this issue Jan 10, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
04789c2
oisincoveney added a commit that referenced this issue Jan 10, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
05f8bfd
oisincoveney added a commit that referenced this issue Jan 11, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
eee547f
oisincoveney added a commit that referenced this issue Jan 11, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
805bc75
oisincoveney added a commit that referenced this issue Jan 11, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
fa101a2
oisincoveney added a commit that referenced this issue Jan 11, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
2f24170
oisincoveney added a commit that referenced this issue Jan 12, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
ecfd6c5 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 12, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
e1e0a78 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 12, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
20f0113 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
@oisincoveney oisincoveney mentioned this issue Jan 12, 2024
Merged
1 task
oisincoveney added a commit that referenced this issue Jan 12, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
bc3c3bf 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 15, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
4ebdc30 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 15, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
65f53cf 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 15, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
0a52896 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 16, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
111e5be 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 18, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
48b1d5e
oisincoveney added a commit that referenced this issue Jan 18, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
bf74a7b 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 18, 2024
@oisincoveney
[#35961 M4] Add legalese step without any checks (#37008)
fee16d5
oisincoveney added a commit that referenced this issue Jan 18, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
23d587f 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 18, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
43853e0 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
oisincoveney added a commit that referenced this issue Jan 19, 2024
@oisincoveney @noahmoss
[#35961 M4] Add backend verification for accepting embedding legalese (…
fc335f9 
…#37327)

Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
@oisincoveney oisincoveney mentioned this issue Jan 19, 2024
Merged
1 task
oisincoveney added a commit that referenced this issue Jan 19, 2024
@oisincoveney @noahmoss
[Epic #35961] Milestone 4 - Add Legalese Step (#37006)
b4c9d98 
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
@albertoperdomo albertoperdomo mentioned this issue Jan 22, 2024
Closed
@WiNloSt WiNloSt mentioned this issue Jan 30, 2024
Merged
1 task
@WiNloSt WiNloSt added this to the 0.49 milestone Feb 6, 2024
@NevRA NevRA closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniskaber deniskaber

@oisincoveney oisincoveney

Labels
.Epic Feature Implementation or Project .Team/Embedding
Projects
None yet
Milestone
0.49
Development

When branches are created from issues, their pull requests are automatically linked.

35961-epic-setup-flow-for-staticpublic-embedding-embedding-feature-discoverability metabase/metabase
4 participants
@NevRA @WiNloSt @deniskaber @oisincoveney