New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass all config in constructor #280
Comments
Hmm, yeah it does seem like a good idea to expose an API for building a Metalsmith object from the config file format used by the CLI. Not sure we'd be able to implement this the exact same way though, as the constructor function currently requires a Seems like a pretty reasonable request though. Also probably worth mentioning #205 here, since that's somewhat related... |
Maybe we can just introduce options parameter?
This way it's backward compatible and nothing have to change for the Metalsmith config. |
@kievechua Something like that could work. Though as I alluded to in my previous comment, if we're splitting the CLI out from Metalsmith it might be better to include this API in that project instead. I'm not completely sure though. What's the use-case for this? Are you just looking for a cleaner API? |
We're thinking of building it with build system like fly or etc. Let me know if there's a better way to do it. |
Well for now you can always just use the existing API right? This feature wouldn't really add any new functionality, it'd just be an extra way of configuring Metalsmith using a different API. |
No worry on it, I'm using existing method to call on it. |
Is there a plan to pass config as following?
The text was updated successfully, but these errors were encountered: