Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to gist sharing in README not working #144

Open
Symbolics opened this issue Jan 8, 2021 · 2 comments
Open

Links to gist sharing in README not working #144

Symbolics opened this issue Jan 8, 2021 · 2 comments

Comments

@Symbolics
Copy link

The links to the vega-editor gists are not working in Chrome nor Firefox. Attempting to load the gist from the vega editor directly produces:

[Error] Invalid specification {"$schema":"https://vega.github.io/schema/vega-lite/v4.json"}. Make sure the specification includes at least one of the following properties: "mark", "layer", "facet", "hconcat", "vconcat", "concat", or "repeat".
@metasoarous
Copy link
Owner

Hi Symbolics. Thanks for posting.

I thought I responded to this already, but must have failed to submit the comment.

I checked and at least some of these links still work (e.g. https://vega.github.io/editor/#/gist/vega-lite/metasoarous/87a5621b0dbec648b2b54f68b3354c3a/e1d471b5a5619a1f6f94e38b2673feff15056146/vega-viz.json). Can you please point to the one that's failing?

It was weird that the first time I loaded that there was a stray x at the end of the json string, but after editing that out and reloading it worked... The underlying gist doesn't have any such content in it though, so perhaps this was a bug with the vega editor?

Please let me know if you have any more information which might be helpful.

Thanks again.

@wongjoel
Copy link
Contributor

When I try to load https://vega.github.io/editor/#/gist/vega-lite/metasoarous/87a5621b0dbec648b2b54f68b3354c3a/e1d471b5a5619a1f6f94e38b2673feff15056146/vega-viz.json , all I see is the last thing I opened in the vega editor, so perhaps there is a problem with the editor, or it changed how the url is interpreted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants