Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Error during capture stitching caused by overridden Object constructor #16

Closed
marchingon12 opened this issue Sep 2, 2020 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@marchingon12
Copy link

image

@meyfa
Copy link
Owner

meyfa commented Sep 2, 2020

What's your operating system, and the version of Atom you're using?

@meyfa meyfa added the bug Something isn't working label Sep 2, 2020
@marchingon12
Copy link
Author

marchingon12 commented Sep 13, 2020

I'm running Manjaro KDE (Arch Linux based), Atom version 1.50.0 x64.
Steps to reproduce:

  • right-click anywhere within code and 'Take Code Screenshot'.

p.s. it now works for some reason, I have not changed anything.

@meyfa
Copy link
Owner

meyfa commented Sep 16, 2020

Apparently in some circumstances the constructor name for every single object object is set to NativeImage (?!). Sample from the developer console inside Atom:

> new Object().constructor.name
< "NativeImage"

This throws the merge-images dependency off guard, resulting in the above error.
If someone can figure out why this happens, I would really like to know.

Sometimes the constructor is not overridden. I reloaded the Atom window several times and the behavior was pretty much random.

Suggestions for how to approach this are very much welcome, as well.

@meyfa meyfa added the help wanted Extra attention is needed label Sep 16, 2020
@meyfa
Copy link
Owner

meyfa commented Sep 16, 2020

It seems that Electron had a few problems of that sort, e.g.:

electron/electron#22820

electron/electron#20637

@meyfa meyfa changed the title Unable to screenshot at all Error during capture stitching caused by overriden Object constructor Sep 16, 2020
@meyfa meyfa changed the title Error during capture stitching caused by overriden Object constructor Error during capture stitching caused by overridden Object constructor Sep 16, 2020
@meyfa
Copy link
Owner

meyfa commented Nov 12, 2020

I think this is no longer a problem with Atom 1.52+ because of an internal Electron update. Can you confirm the issue is resolved?

@meyfa meyfa removed the help wanted Extra attention is needed label Dec 6, 2020
@meyfa
Copy link
Owner

meyfa commented Dec 6, 2020

Closing because there was no more action on this issue.

@meyfa meyfa closed this as completed Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants