Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RequestHandlerRunner factory with RequestHandlerRunnerInterface factory #114

Open
boesing opened this issue Apr 20, 2022 · 3 comments · May be fixed by #167
Open

Replace RequestHandlerRunner factory with RequestHandlerRunnerInterface factory #114

boesing opened this issue Apr 20, 2022 · 3 comments · May be fixed by #167
Labels
BC Break Enhancement New feature or request
Milestone

Comments

@boesing
Copy link
Member

boesing commented Apr 20, 2022

We have to remove the alias RequestHandlerRunnerInterface introduced in #110 and instead add it to the factories.
This should also remove the RequestHandlerRunner factory so that the RequestHandlerRunner service is not available via the container anymore.

This introduces a BC break but will provide better capabilities for projects which want to decorate the runner.


This can go to 3.11.x indeed, but we should change this from aliases to factories in 4.x since RequestHandlerRunner should not be requestable as a service from the container.

Since delegators only work on services, this would be a BC break for sure and therefore I'd like to keep this in mind and thus dropping it here. Creating a new issue for 4.x from this comment to keep track.

Originally posted by @boesing in #110 (comment)

@boesing boesing added BC Break Enhancement New feature or request labels Apr 20, 2022
@boesing boesing added this to the 4.0.0 milestone Apr 20, 2022
@boesing
Copy link
Member Author

boesing commented May 8, 2023

Might be superseded with laminas/laminas-servicemanager#168

@mlussi90
Copy link

mlussi90 commented Oct 19, 2023

Tried to provide the Code Change: #166

@mlussi90
Copy link

i created a new PR based on 4.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants