routes => middleware => multiple actions does not get lazy loaded

[weierophinney]

Example:
config

    [
        'name'            => 'my.post',
        'path'            => "/my",
        'middleware'      => [
            Action\PostAction::class,
            Action\PostAction2::class, // add another action to react on path
        ],
        'allowed_methods' => ['POST'],
    ],

Im using a middleware (priority PHP_INT_MAX) to catch fatal error (register_shutdown_function).
When im using one action only in the config
and when i force an fatal error in that action
the registered shutdown function gets called.

If im using two actions as shown above
then no registered shutdown function gets called.
The middleware im using wont be invoked/loaded before the action.

---

Originally posted by @cottton at zendframework/zend-expressive#361

[weierophinney]

It depends on what code you have in those actions. Usually you return a Response object in an action middleware. Which basically means you will not execute the second action but go back through all the previous middleware.

What you can have in that middleware is something like this:

        'middleware'      => [
            Middleware\SessionMiddleware::class,
            Middleware\AuthMiddleware::class,
            Action\PostAction::class
        ],

---

Originally posted by @geerteltink at zendframework/zend-expressive#361 (comment)

[weierophinney]

Both actions return $next(...) if there is $next.
Here an example case:

test.global.php

<?php
return [
    'dependencies'        => [
        'invokables' => [
            App\ErrorHandler::class => App\ErrorHandler::class,
            App\TestAction::class   => App\TestAction::class,
            App\TestAction2::class   => App\TestAction2::class,
        ],
    ],
    'routes'              => [
        [
            'name'            => 'test',
            'path'            => '/test',
            'middleware'      => [
                App\TestAction::class,
                App\TestAction2::class, 
            ],
            'allowed_methods' => ['POST'],
        ],
    ],
    'middleware_pipeline' => [
        [
            'middleware' => App\ErrorHandler::class,
            'priority'   => PHP_INT_MAX, // always first
        ],
    ],
];

App\ErrorHandler.php

<?php
namespace App;

use Zend\Stratigility\MiddlewareInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

class ErrorHandler implements MiddlewareInterface
{
    public function __invoke(
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next = null
    ) {
        file_put_contents('data/test.txt', __METHOD__ . PHP_EOL, FILE_APPEND);

        set_error_handler(
            function (
                $errorNumber,
                $errorString,
                $errorFile = '',
                $errorLine = ''
            ) {
                file_put_contents(
                    'data/set_error_handler.txt',
                    implode(
                        ', ',
                        [
                            $errorNumber,
                            $errorString,
                            $errorFile,
                            $errorLine
                        ]
                    ) . PHP_EOL, FILE_APPEND
                );
            }
        );

        register_shutdown_function(
            function () {
                $errorLast = error_get_last();
                if ($errorLast) {
                    file_put_contents(
                        'data/register_shutdown_function.txt',
                        implode(', ', $errorLast) . PHP_EOL, FILE_APPEND
                    );
                }
            }
        );

        if ($next) {
            $response = $next($request, $response);
        }
        return $response;
    }
}

App\TextAction.php

<?php
namespace App;

use Zend\Stratigility\MiddlewareInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

class TestAction implements MiddlewareInterface
{
    public function __invoke(
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next = null
    ) {
        file_put_contents('data/test.txt', __METHOD__ . PHP_EOL, FILE_APPEND);

        $response = $response->withHeader('test', 'test');

        if ($next) {
            $response = $next($request, $response);
        }
        return $response;
    }
}

App\TestAction2.php

<?php
namespace App;

use Zend\Stratigility\MiddlewareInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

class TestAction2 implements MiddlewareInterface
{
    public function __invoke(
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next = null
    ) {
        file_put_contents('data/test.txt', __METHOD__ . PHP_EOL, FILE_APPEND);

        $response = $response->withHeader('test2', 'test2');

        if ($next) {
            $response = $next($request, $response);
        }
        return $response;
    }
}

---

Without any error you will get an data/text.txt with content:

App\ErrorHandler::__invoke
App\TestAction::__invoke
App\TestAction2::__invoke

---

If you now force an fatal error in App\TestAction.php the App\ErrorHandler.php wont get invoked.
Expected:

App\ErrorHandler::__invoke

Got: empty

---

If you now force an fatal error in App\TestAction2.php the App\ErrorHandler.php will get invoked.

Expected:

App\ErrorHandler::__invoke
App\TestAction::__invoke

Got:

App\ErrorHandler::__invoke
App\TestAction::__invoke

For some reason the register_shutdown_function wont get executed at all in this cases oO?

---

Originally posted by @cottton at zendframework/zend-expressive#361 (comment)

[weierophinney]

@sergu44o What version are you using? This issue is almost 2 years old.

---

Originally posted by @geerteltink at zendframework/zend-expressive#361 (comment)