Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move router integration tests to router packages #94

Open
boesing opened this issue Oct 13, 2021 · 0 comments
Open

Move router integration tests to router packages #94

boesing opened this issue Oct 13, 2021 · 0 comments
Labels

Comments

@boesing
Copy link
Member

boesing commented Oct 13, 2021

RFC

Q A
Proposed Version(s) 3.7.0
BC Break? No

Goal

To unblock PHP 8.1 support from this package, we should remove all router integration tests and only do unit tests when it comes to integration tests (and/or use our own laminas-router where we actually can always provide patches to be compatible with new versions - e.g. PHP or major versions of this package).

Background

mezzio/mezzio-aurarouter does not support PHP 8.1 yet. To provide proper 8.1 support (without deprecation warnings), we would have to provide patches to https://github.com/auraphp/Aura.Router
To avoid having that huge amount of work until we can get this package ready for 8.1, we should move all integration tests to the related components.

Considerations

Users wont have any impact on this as we only require these packages for integration tests.

Proposal(s)

  1. Remove all integration tests from here (or keep those we actually can maintain by ourselves)
  2. Provide support for PHP 8.1

Appendix

If we do want to keep that package, we should at least remove integration tests from this package and port them to the router component.

@boesing boesing added the RFC label Oct 13, 2021
@boesing boesing added this to the 3.7.0 milestone Oct 13, 2021
@weierophinney weierophinney modified the milestones: 3.7.0, 3.8.0 Dec 1, 2021
@Ocramius Ocramius removed this from the 3.8.0 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants