Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/MaxRowNumber wrong index #104

Open
DanielSanIT opened this issue Feb 15, 2021 · 5 comments
Open

Min/MaxRowNumber wrong index #104

DanielSanIT opened this issue Feb 15, 2021 · 5 comments
Labels

Comments

@DanielSanIT
Copy link

I am trying to read specific rows. Rows that I specified in ExcelMapper has different from actual Excel file rows.
I set MinRowNumber = 9, MaxRowNumber = 19, but the library has returned rows from 10 to 20

@archerbird
Copy link

Is there, by chance, a filter applied in your excel file?

@DanielSanIT
Copy link
Author

Is there, by chance, a filter applied in your excel file?

There is no a filter.
I tried it on clean excel - same problem.
Maybe it related to "HeaderRow = false"?
I am just trying to reed data from row 10 to 20

@mganss
Copy link
Owner

mganss commented Feb 16, 2021

Can't verify right now but I think row numbers start at 0 in ExcelMapper while they start at 1 in Excel.

@DanielSanIT
Copy link
Author

Ok then it will be a good issue to make 1 based index in ExcelMapper to be similar with Excel.

@mganss
Copy link
Owner

mganss commented Feb 16, 2021

I'll leave it this way for now as this would be a major breaking change. POI also uses 0-based row numbering. ExcelMapper is admittedly inconsistent as column numbers are 1-based.

@mganss mganss added the wontfix label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants