Skip to content

Commit c69e2ae

Browse files
rafaelss95mgechev
authored andcommittedAug 28, 2018
fix(no-unused-css): blank lines being left after fixing (#701)
1 parent 0bac287 commit c69e2ae

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

‎src/noUnusedCssRule.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ class UnusedCssVisitor extends BasicCssAstVisitor {
169169
} = ast;
170170
// length + 1 because we want to drop the '}'
171171
const length = endOffset - startOffset + 1;
172-
this.addFailureAt(startOffset, length, 'Unused styles', this.createReplacement(startOffset, length, ''));
172+
this.addFailureAt(startOffset, length, 'Unused styles', Lint.Replacement.deleteText(startOffset - 1, length + 1));
173173
}
174174
} catch (e) {
175175
logger.error(e);

‎test/noUnusedCssRule.spec.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -868,8 +868,8 @@ describe('no-unused-css', () => {
868868
)!;
869869
const replacement = failures[0].getFix() as Replacement;
870870
expect(replacement.text).to.eq('');
871-
expect(replacement.start).to.eq(199);
872-
expect(replacement.end).to.eq(246);
871+
expect(replacement.start).to.eq(14);
872+
expect(replacement.end).to.eq(62);
873873
});
874874

875875
it('should work with SASS', () => {
@@ -919,8 +919,8 @@ describe('no-unused-css', () => {
919919
Config.transformStyle = (code: string) => ({ code, map: null });
920920
const replacement = failures[0].getFix() as Replacement;
921921
expect(replacement.text).to.eq('');
922-
expect(replacement.start).to.eq(168);
923-
expect(replacement.end).to.eq(271); // should be 276
922+
expect(replacement.start).to.eq(-1);
923+
expect(replacement.end).to.eq(29);
924924
});
925925
});
926926

0 commit comments

Comments
 (0)
Please sign in to comment.