Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mgechev/codelyzer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.4.1
Choose a base ref
...
head repository: mgechev/codelyzer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.4.2
Choose a head ref
  • 6 commits
  • 8 files changed
  • 3 contributors

Commits on Jun 24, 2018

  1. docs(readme): add missing rules (#673)

    @rafaelss95 @mgechev
    rafaelss95 authored and mgechev committed Jun 24, 2018
    Copy the full SHA
    28bd75a View commit details

  2. fix(no-output-on-prefix): fix regular expression (#674) 

    * fix(no-output-on-prefix): fix regular expression

this commit fixes incorrect behavior when memberName contains 'on' suffix in the word, for example selectionChanged.

```
/on((?![a-z])|(?=$))/.test('selectionChanged');
// true

/^on((?![a-z])|(?=$))/.test('selectionChanged');
// false
```

* test(no-output-on-prefix): add more test cases

* style(no-output-on-prefix): fix misspellings
    @loktionov129 @mgechev
    loktionov129 authored and mgechev committed Jun 24, 2018
    Copy the full SHA
    adc974a View commit details

  3. docs: update changelog (#677)

    @rafaelss95 @mgechev
    rafaelss95 authored and mgechev committed Jun 24, 2018
    Copy the full SHA
    de3cd32 View commit details

  4. build: add standard-version and commitlint packages (#675)

    @rafaelss95 @mgechev
    rafaelss95 authored and mgechev committed Jun 24, 2018
    Copy the full SHA
    4dfa89c View commit details

  5. build: lint-staged not being triggered on precommit hook (#676)

    @rafaelss95 @mgechev
    rafaelss95 authored and mgechev committed Jun 24, 2018
    Copy the full SHA
    52b94f7 View commit details

Commits on Jun 25, 2018

  1. chore(release): 4.4.2

    @mgechev
    mgechev committed Jun 25, 2018
    Copy the full SHA
    6942e18 View commit details
Showing with 3,122 additions and 42 deletions.
  1. +3 −0 .commitlintrc.json
  2. +41 −14 CHANGELOG.md
  3. +11 −0 README.md
  4. +2,057 −3 package-lock.json
  5. +7 −1 package.json
  6. +1 −1 src/noOutputOnPrefixRule.ts
  7. +10 −0 test/noOutputOnPrefixRule.spec.ts
  8. +992 −23 yarn.lock
3 changes: 3 additions & 0 deletions .commitlintrc.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": ["@commitlint/config-angular"]
}
55 changes: 41 additions & 14 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,24 +1,51 @@
# 4.4.1
# Change Log

## Bug Fixes
All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

* TypeError: ts.isStringLiteralLike is not a function [#669](https://github.com/mgechev/codelyzer/issues/669) [d922dcb](https://github.com/mgechev/codelyzer/commit/d922dcb5c7fdb6bb99efb8b6cb6000dfc0c12f1c)
* prefer-inline-decorator is missing in v4.4 [#670](https://github.com/mgechev/codelyzer/issues/670) [d922dcb](https://github.com/mgechev/codelyzer/commit/d922dcb5c7fdb6bb99efb8b6cb6000dfc0c12f1c)
<a name="4.4.2"></a>

# 4.4.0
## [4.4.2](https://github.com/mgechev/codelyzer/compare/4.4.1...4.4.2) (2018-06-25)

## New Rules
### Bug Fixes

* **no-output-on-prefix:** fix regular expression ([#674](https://github.com/mgechev/codelyzer/issues/674)) ([adc974a](https://github.com/mgechev/codelyzer/commit/adc974a))

<a name="4.4.1"></a>

# [4.4.1](https://github.com/mgechev/codelyzer/compare/4.4.0...4.4.1) (2018-06-23)

### Bug Fixes

* regressions in 4.4.0 ([#671](https://github.com/mgechev/codelyzer/issues/671)) ([d922dcb](https://github.com/mgechev/codelyzer/commit/d922dcb)), closes [#669](https://github.com/mgechev/codelyzer/issues/669), [#670](https://github.com/mgechev/codelyzer/issues/670)

* Add no-queries-parameter rule [#572](https://github.com/mgechev/codelyzer/issues/572) [e9f4d23](https://github.com/mgechev/codelyzer/commit/e9f4d2303c5b95cf8623ac91b114c6428e832ef0)
* [Feature Request] Enforce single line @Input decorator [#549](https://github.com/mgechev/codelyzer/issues/549) [5d5e21d](https://github.com/mgechev/codelyzer/commit/5d5e21d4e8cff3b4bb1afc88d23ac6e34fe28c83)
<a name="4.4.0"></a>

## New Features
# [4.4.0](https://github.com/mgechev/codelyzer/compare/4.3.0...4.4.0) (2018-06-23)

### Bug Fixes

* **no-input-prefix:** exact strings not being reported ([#597](https://github.com/mgechev/codelyzer/issues/597)) ([1ed8d8c](https://github.com/mgechev/codelyzer/commit/1ed8d8c))
* **no-input-rename:** aria attributes not being allowed to be renamed ([#665](https://github.com/mgechev/codelyzer/issues/665)) ([2c905ab](https://github.com/mgechev/codelyzer/commit/2c905ab)), closes [#663](https://github.com/mgechev/codelyzer/issues/663)
* **no-input-rename:** fix bugs ([#585](https://github.com/mgechev/codelyzer/issues/585)) ([75f9de6](https://github.com/mgechev/codelyzer/commit/75f9de6)), closes [#580](https://github.com/mgechev/codelyzer/issues/580)
* **no-template-call-expression:** not being exported ([#582](https://github.com/mgechev/codelyzer/issues/582)) ([ad57552](https://github.com/mgechev/codelyzer/commit/ad57552)), closes [#577](https://github.com/mgechev/codelyzer/issues/577)
* **no-life-cycle-call:** fix bugs ([#575](https://github.com/mgechev/codelyzer/issues/575)) ([4415cc2](https://github.com/mgechev/codelyzer/commit/4415cc2)), closes [#573](https://github.com/mgechev/codelyzer/issues/573)
* **no-input-prefix:** not being able to check for multiple concurrent prefixes ([#590](https://github.com/mgechev/codelyzer/issues/590)) ([43d415a](https://github.com/mgechev/codelyzer/commit/43d415a)), closes [#589](https://github.com/mgechev/codelyzer/issues/589)
* **no-output-rename:** not being reported for some cases ([#614](https://github.com/mgechev/codelyzer/issues/614)) ([5e34f41](https://github.com/mgechev/codelyzer/commit/5e34f41)), closes [#613](https://github.com/mgechev/codelyzer/issues/613)
* **template-conditional-complexity:** not reporting failures for '[ngIf]' ([#611](https://github.com/mgechev/codelyzer/issues/611)) ([7fc3b09](https://github.com/mgechev/codelyzer/commit/7fc3b09)), closes [#607](https://github.com/mgechev/codelyzer/issues/607)
* **template-cyclomatic-complexity:** not reporting failures for '[ngForOf]' and '[ngIf]' ([#612](https://github.com/mgechev/codelyzer/issues/612)) ([fedd331](https://github.com/mgechev/codelyzer/commit/fedd331)), closes [#609](https://github.com/mgechev/codelyzer/issues/609)
* **trackBy-function:** not reporting failures for '[ngForOf]' ([#610](https://github.com/mgechev/codelyzer/issues/610)) ([af52912](https://github.com/mgechev/codelyzer/commit/af52912)), closes [#608](https://github.com/mgechev/codelyzer/issues/608)
* some rules not considering options correctly ([#617](https://github.com/mgechev/codelyzer/issues/617)) ([bce0026](https://github.com/mgechev/codelyzer/commit/bce0026))

### Features

* no-input-rename rule should allow aliasing dashed properties [#663](https://github.com/mgechev/codelyzer/issues/663) [2c905ab](https://github.com/mgechev/codelyzer/commit/2c905abd17aef1203f2726bf82ba805c3bfe9861)
* export NgWalker for library users [#657](https://github.com/mgechev/codelyzer/issues/657) [b79ea58](https://github.com/mgechev/codelyzer/commit/b79ea5887235d4b38fe261fa34aba58c5d16a17f)
* Upgrade TypeScript dependency to 2.7.2 [#583](https://github.com/mgechev/codelyzer/issues/583) [d4bf62d](https://github.com/mgechev/codelyzer/commit/d4bf62d8134075f0ed1f1fa3d83b5be9f7c1918d)
* Build scripts are not cross-platform [#454](https://github.com/mgechev/codelyzer/issues/454) [204c8ef](https://github.com/mgechev/codelyzer/commit/204c8ef2f20498d216e0fd9b9f602cf216186158)
* Turn on strict TS compilation mode [#629](https://github.com/mgechev/codelyzer/issues/629) [da0f553](https://github.com/mgechev/codelyzer/commit/da0f553fe7d580f38907f9baa9124cbc55e37c96)
* **import-destructuring-spacing:** add fixer ([#595](https://github.com/mgechev/codelyzer/issues/595)) ([2acc27b](https://github.com/mgechev/codelyzer/commit/2acc27b))
* **max-inline-declarations:** add option to limit animations lines ([#569](https://github.com/mgechev/codelyzer/issues/569)) ([25f3e16](https://github.com/mgechev/codelyzer/commit/25f3e16)), closes [#568](https://github.com/mgechev/codelyzer/issues/568)
* **rule:** add no-queries-parameter rule ([#571](https://github.com/mgechev/codelyzer/issues/571)) ([e9f4d23](https://github.com/mgechev/codelyzer/commit/e9f4d23))
* **rule:** add prefer-inline-decorator rule ([#586](https://github.com/mgechev/codelyzer/issues/586)) ([5d5e21d](https://github.com/mgechev/codelyzer/commit/5d5e21d)), closes [#549](https://github.com/mgechev/codelyzer/issues/549)
* build scripts are not cross-platform [#581](https://github.com/mgechev/codelyzer/issues/581) [204c8ef](https://github.com/mgechev/codelyzer/commit/204c8ef), closes [#454](https://github.com/mgechev/codelyzer/issues/454)
* upgrade TypeScript dependency to 2.7.2 [#584](https://github.com/mgechev/codelyzer/issues/584) [d4bf62d](https://github.com/mgechev/codelyzer/commit/d4bf62d), closes [#583](https://github.com/mgechev/codelyzer/issues/583)
* turn on strict TS compilation mode ([#631](https://github.com/mgechev/codelyzer/issues/631)) ([da0f553](https://github.com/mgechev/codelyzer/commit/da0f553)), closes [#629](https://github.com/mgechev/codelyzer/issues/629)
* externalizing template, css visitor abstractions and NgWalker ([#658](https://github.com/mgechev/codelyzer/issues/658)) ([b79ea58](https://github.com/mgechev/codelyzer/commit/b79ea58))

Credits to the codelyzer's [maintainers and contributors](https://github.com/mgechev/codelyzer#contributors).

11 changes: 11 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,8 @@
[![Downloads](https://img.shields.io/npm/dt/codelyzer.svg)](https://img.shields.io/npm/dt/codelyzer.svg)
[![Build Status](https://travis-ci.org/mgechev/codelyzer.svg?branch=master)](https://travis-ci.org/mgechev/codelyzer)
[![Build status](https://ci.appveyor.com/api/projects/status/7xj7qs0a0h0ald53?svg=true)](https://ci.appveyor.com/project/mgechev/codelyzer)
[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
[![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-yellow.svg)](https://conventionalcommits.org)
[![Gitter Chat](https://camo.githubusercontent.com/da2edb525cde1455a622c58c0effc3a90b9a181c/68747470733a2f2f6261646765732e6769747465722e696d2f4a6f696e253230436861742e737667)](https://gitter.im/mgechev/codelyzer)

<p align="center">
@@ -104,6 +106,8 @@ Create the following `tslint.json` file like:
"prefer-output-readonly": true,
"no-conflicting-life-cycle-hooks": true,
"enforce-component-selector": true,
"no-queries-parameter": true,
"prefer-inline-decorator": true,
"use-input-property-decorator": true,
"use-output-property-decorator": true,
"use-host-property-decorator": true,
@@ -163,6 +167,8 @@ Now create the following `tslint.json` file where your `node_modules` directory
"prefer-output-readonly": true,
"no-conflicting-life-cycle-hooks": true,
"enforce-component-selector": true,
"no-queries-parameter": true,
"prefer-inline-decorator": true,
"use-input-property-decorator": true,
"use-output-property-decorator": true,
"use-host-property-decorator": true,
@@ -274,6 +280,8 @@ Below you can find a recommended configuration which is based on the [Angular St
"prefer-output-readonly": true,
"no-conflicting-life-cycle-hooks": true,
"enforce-component-selector": true,
"no-queries-parameter": true,
"prefer-inline-decorator": true,

// [ENABLED, "SUFFIX"]
// Where "SUFFIX" is your custom suffix, for instance "Page" for Ionic 2 components.
@@ -315,6 +323,9 @@ Below you can find a recommended configuration which is based on the [Angular St
| `prefer-output-readonly` | Stable |
| `enforce-component-selector` | Stable |
| `no-life-cycle-call` | Stable |
| `no-template-call-expression` | Stable |
| `no-queries-parameter` | Stable |
| `prefer-inline-decorator` | Stable |
| `no-conflicting-life-cycle-hooks` | _Experimental_ |
| `i18n` | _Experimental_ |
| `no-unused-css` | _Experimental_ |
Loading