Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better logging of errors required #229

Closed
negberts opened this issue Feb 9, 2017 · 3 comments · Fixed by #239
Closed

Better logging of errors required #229

negberts opened this issue Feb 9, 2017 · 3 comments · Fixed by #239
Assignees
@mgechev
Labels
enhancement first timers P3
Milestone
2.0.1 - Boomerang

Comments

@negberts
Copy link

negberts commented Feb 9, 2017 •
edited

With the new package we get errors like 'You can bind only to public class members.' with occur to happen at line 1, column 1 of the HTML template. But the template has <div class="main-menu-button"> on the first line.

If I look to the code of the templatesUsePublicRule the specific member is known. So could we at least have the name of the member or method that is causing the error in the error message and not a generic error?
@mgechev
Copy link
Owner

mgechev commented Feb 9, 2017

Yes, I'll include this in the backlog.

@mgechev mgechev self-assigned this Feb 9, 2017
@mgechev mgechev modified the milestones: 2.0.1 - Swallow Rock, 2.0.2 - Actualism Feb 19, 2017
@mgechev
Copy link
Owner

mgechev commented Feb 19, 2017

@negberts it'll be amazing if you have time to open a PR! The change will not require deep understanding of the project.

comfroels added a commit to comfroels/codelyzer that referenced this issue Feb 19, 2017
@comfroels
fix(templatesUsePublicRule): Pass member name back through error
0b7e459 
Pass the class member name to the error for more clarification

fixes mgechev#229
@comfroels comfroels mentioned this issue Feb 19, 2017
Merged
@mgechev mgechev modified the milestones: 2.0.1 - Swallow Rock, 2.0.2 - Actualism Feb 19, 2017
@negberts
Copy link
Author

Sorry, just had a little baby girl so no spare time left :) But I see somebody else was helpfull!

mgechev pushed a commit that referenced this issue Feb 19, 2017
@comfroels @mgechev
fix(templatesUsePublicRule): Pass member name back through error
d622b9a 
Pass the class member name to the error for more clarification

fixes #229
@mgechev mgechev modified the milestones: 2.0.1 - Boomerang, 3.0.0-rc.0 - Swallow Rock Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgechev mgechev

Labels
enhancement first timers P3
Projects
None yet
Milestone
2.0.1 - Boomerang
Development

Successfully merging a pull request may close this issue.

fix(templatesUsePublicRule): Pass member name back through error comfroels/codelyzer
2 participants
@mgechev @negberts