Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto fix for check-interpolation part of angularWhitespace is broken #345

Closed
mgechev opened this issue Jun 21, 2017 · 5 comments
Closed

Comments

@mgechev
Copy link
Owner

mgechev commented Jun 21, 2017

No description provided.

@wKoza
Copy link
Collaborator

wKoza commented Jul 2, 2017

Fixed by #362

@wKoza wKoza closed this as completed Jul 2, 2017
@Matmo10
Copy link

Matmo10 commented Jul 3, 2017

Just curious, when would 3.1.2 show up on npm?

@mgechev
Copy link
Owner Author

mgechev commented Jul 3, 2017

@Matmo10 I'll try to push it tomorrow.

@Matmo10
Copy link

Matmo10 commented Jul 4, 2017

Just tried it out, I still get the following issues with the autofix:

<div class="item-price">{{swimLaneItem.Price.Value| currency:swimLaneItem.Price.Currency:true}}</div>

gets changed to

<div class="item-price">{{ swimLaneItem.Price.Valu e| currency:swimLaneItem.Price.Currency:true }}</div>

Also this

<div class="item-description-content">
   {{itemDescriptionToUse| slice:0:500 }}{{ (itemDescriptionToUse && itemDescriptionToUse.length > 500) ? '&hellip;' : '' }}
</div>

gets changed to this:

<div class="item-description-content">
   {{ itemDescriptionToUs e| slice:0:500 }}{{ (itemDescriptionToUse && itemDescriptionToUse.length > 500) ? '&hellip;' : '' }}
</div>

Also this

<span [hidden]="local.ShippingServiceCost.Value == 0">{{local.ShippingServiceCost.Value|currency:local.ShippingServiceCost.Currency:true}} {{local.ShippingServiceCost.Currency}}</span>

gets changed to this:

<span [hidden]="local.ShippingServiceCost.Value == 0">{{ local.ShippingServiceCost.Valu e |currency:local.ShippingServiceCost.Currency:true }} {{ local.ShippingServiceCost.Currency }}</span>

Seems like an off by one issue with the inserted space before the pipe. Is this a separate issue?

@mgechev
Copy link
Owner Author

mgechev commented Jul 5, 2017

The source of this issue seems the check-pipe option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants