Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-input-prefix] - Bug in concurrent prefixes #589

Closed
rafaelss95 opened this issue Apr 30, 2018 · 0 comments · Fixed by #590
Closed

[no-input-prefix] - Bug in concurrent prefixes #589

rafaelss95 opened this issue Apr 30, 2018 · 0 comments · Fixed by #590

Comments

@rafaelss95
Copy link
Collaborator

rafaelss95 commented Apr 30, 2018

If you have this config in your tslint.json:

{
  "rules": {
    "no-input-prefix": [true, "is", "isc"]
  }
}

it won't report a failure for this:

@Input() iscHange = '';

... but if you change the config to "no-input-prefix": [true, "isc", "is"], it works.

In addition, I don't know if it is intentional, but this rule isn't checking if the alias is prefixed by a non-allowed prefix (it is useful in case where the no-input-rename rule isn't activated for some reason).


In fact, I think this rule should accept a regex rather than an array of strings... something like what I proposed in #576 (for @Output).

@rafaelss95 rafaelss95 changed the title [no-input-prefix] - Bug in competing prefixes [no-input-prefix] - Bug in concurrent prefixes Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant