Skip to content

TypeError: ts.isStringLiteralLike is not a function #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
82antu opened this issue Jun 23, 2018 · 2 comments
Closed

TypeError: ts.isStringLiteralLike is not a function #669

82antu opened this issue Jun 23, 2018 · 2 comments

Comments

@82antu
Copy link

82antu commented Jun 23, 2018

Hi,

I just update right now from 4.3.0 to 4.4.0,...and:

TypeError: ts.isStringLiteralLike is not a function
    at SelectorValidatorWalker.validateProperty (/home/one/master/hfw-core/node_modules/codelyzer/selectorNameBase.js:136:19)
    at /home/one/master/hfw-core/node_modules/codelyzer/selectorNameBase.js:111:85
    at Array.filter (<anonymous>)
    at SelectorValidatorWalker.validateSelector (/home/one/master/hfw-core/node_modules/codelyzer/selectorNameBase.js:111:14)
    at SelectorValidatorWalker.validateDecorator (/home/one/master/hfw-core/node_modules/codelyzer/selectorNameBase.js:102:18)
    at Array.forEach (<anonymous>)
    at SelectorValidatorWalker.visitClassDeclaration (/home/one/master/hfw-core/node_modules/codelyzer/selectorNameBase.js:95:45)
    at SelectorValidatorWalker.SyntaxWalker.visitNode (/home/one/master/hfw-core/node_modules/tslint/lib/language/walker/syntaxWalker.js:314:22)
    at /home/one/master/hfw-core/node_modules/tslint/lib/language/walker/syntaxWalker.js:535:63
    at visitEachNode (/home/one/master/hfw-core/node_modules/typescript/lib/typescript.js:15956:30)
TypeError: ts.isStringLiteralLike is not a function
    at Object.exports.isSimpleTemplateString (/home/one/master/hfw-core/node_modules/codelyzer/util/utils.js:5:15)
    at /home/one/master/hfw-core/node_modules/codelyzer/util/astQuery.js:33:57
    at /home/one/master/hfw-core/node_modules/codelyzer/util/function.js:20:59
    at Maybe.bind (/home/one/master/hfw-core/node_modules/codelyzer/util/function.js:17:54)
    at Maybe.fmap (/home/one/master/hfw-core/node_modules/codelyzer/util/function.js:20:21)
    at Object.getStringInitializerFromProperty (/home/one/master/hfw-core/node_modules/codelyzer/util/astQuery.js:33:10)
    at /home/one/master/hfw-core/node_modules/codelyzer/angular/metadataReader.js:42:55
    at Maybe.bind (/home/one/master/hfw-core/node_modules/codelyzer/util/function.js:17:54)
    at MetadataReader.readDirectiveMetadata (/home/one/master/hfw-core/node_modules/codelyzer/angular/metadataReader.js:42:14)
    at MetadataReader.readComponentMetadata (/home/one/master/hfw-core/node_modules/codelyzer/angular/metadataReader.js:49:38)

Any help is appreciate.

thank in advance
@LukasKlement
Copy link

LukasKlement commented Jun 23, 2018 •
edited
Loading

I'm experiencing the same issue, downgrading to version 4.3.0 fixes it. I'm using typescript@2.7.2

mgechev added a commit that referenced this issue Jun 23, 2018
@mgechev
fix: regressions in 4.4.0

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 3C44F5A2A289C6BB
Learn about vigilant mode
c68b0f7 
- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670
mgechev added a commit that referenced this issue Jun 23, 2018
@mgechev
fix: regressions in 4.4.0

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 3C44F5A2A289C6BB
Learn about vigilant mode
2f23d77 
- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670
@mgechev mgechev mentioned this issue Jun 23, 2018
Merged
mgechev added a commit that referenced this issue Jun 24, 2018
@mgechev
fix: regressions in 4.4.0 (#671)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d922dcb 
* fix: regressions in 4.4.0

- Downgrade to TypeScript 2.7 which is the officially supported on by `@angular/core`
- Export `preferInlineDecoratorRule`

We should introduce a public API guard to make sure we don't hit
regressions like the second one.

Fix #669 #670

* refactor: address comments

* fix: regression in selector type
@mgechev
Copy link
Owner

mgechev commented Jun 24, 2018

Fixed in 4.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgechev @LukasKlement @82antu