Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule): add pipe-prefix rule #693

Merged
merged 4 commits into from Aug 2, 2018
Merged

Conversation

sneas
Copy link
Contributor

@sneas sneas commented Jul 26, 2018

Following #519 and #593 discussions adding pipe-prefix rule and pointing users to it in pipe-naming deprecation.

@sneas
Copy link
Contributor Author

sneas commented Jul 26, 2018

@mgechev thanks for codelyzer and please let me know if anything should be updated and if this PR makes any sense at all.

I'm not sure about messages correctness. English language is not my strongest side.

@sneas
Copy link
Contributor Author

sneas commented Jul 26, 2018

I've just discovered some test cases cause this error:

AssertionError: end char doesn't match: expected { line: 2, character: 25 } to deeply equal { line: 2, character: 24 }
    at Function.assert.deepEqual (/Users/travis/build/mgechev/codelyzer/node_modules/chai/lib/chai/interface/assert.js:216:32)
    at assertFailure (/Users/travis/build/mgechev/codelyzer/dist/test/testHelper.js:126:23)
    at Object.assertAnnotated (/Users/travis/build/mgechev/codelyzer/dist/test/testHelper.js:90:16)
    at Context.<anonymous> (/Users/travis/build/mgechev/codelyzer/dist/test/pipePrefixRule.spec.js:8:26)
    at callFn (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runnable.js:383:21)
    at Test.Runnable.run (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runnable.js:375:7)
    at Runner.runTest (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:446:10)
    at /Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:564:12
    at next (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:360:14)
    at /Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:370:7
    at next (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:294:14)
    at Immediate._onImmediate (/Users/travis/build/mgechev/codelyzer/node_modules/mocha/lib/runner.js:338:5)
    at runCallback (timers.js:696:18)
    at tryOnImmediate (timers.js:667:5)
    at processImmediate (timers.js:649:5)

Fixed with this commit f388737

@mgechev mgechev added this to the Tony Hoare milestone Aug 2, 2018
@mgechev mgechev merged commit 71660ae into mgechev:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants