New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assertFailure catch exception throw by assert (#703) #704

Merged

mgechev merged 1 commit into mgechev:master from someblue:master

Aug 24, 2018

Contributor

someblue commented Aug 24, 2018

Fix #703.

I think try catch statement inside assertFailure() is unnecessary. Because:

If exception happens in lint(), this test case should be treated as a fail test. This exception should be catch by Chai.
It's unnecessary to print exception stack. Chai will print it in a better place and format.


          fix: assertFailure catch exception throw by assert (mgechev#703)

a2fa7b4

mgechev approved these changes

View reviewed changes

mgechev merged commit 0bac287 into mgechev:master

snyk-bot mentioned this pull request

[Snyk] Upgrade codelyzer from 4.3.0 to 4.5.0 Narshe1412/nuarca-sql#24

Closed

snyk-bot mentioned this pull request

[Snyk] Upgrade codelyzer from 4.3.0 to 4.5.0 Narshe1412/nuarca-sql#48

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment