Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trackBy-function not reporting failures involving multiple *ngFor directives #718

Closed
axelboc opened this issue Oct 22, 2018 · 1 comment · Fixed by #721
Closed

trackBy-function not reporting failures involving multiple *ngFor directives #718

axelboc opened this issue Oct 22, 2018 · 1 comment · Fixed by #721

Comments

@axelboc
Copy link

axelboc commented Oct 22, 2018

I have two *ngFor directives within the same template.

  • If neither has a trackBy function, rule trackBy-function reports two failures. ✅
  • If only the first one has a trackBy function and the second one doesn't, rule trackBy-function doesn't report any failure. ❌
@wKoza
Copy link
Collaborator

wKoza commented Oct 23, 2018

Thanks for your report. We're going to figure out the problem.

This was referenced Oct 26, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

should fail when we have two ngFor and the second trackBy function is… wKoza/codelyzer
Gh 718
2 participants
@axelboc @wKoza