New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): autofocus attribute should not be used #749

Merged

mgechev merged 1 commit into mgechev:master from mohammedzamakhan:no-autofocus

Feb 11, 2019

Contributor

mohammedzamakhan commented Feb 9, 2019

No description provided.

mgechev reviewed

View reviewed changes

test/templateNoAutofocusRule.spec.ts Outdated Show resolved Hide resolved

mgechev reviewed

View reviewed changes

test/templateNoAutofocusRule.spec.ts Outdated Show resolved Hide resolved

mgechev reviewed

View reviewed changes

test/templateNoAutofocusRule.spec.ts Outdated Show resolved Hide resolved

mgechev reviewed

View reviewed changes

src/templateNoAutofocusRule.ts Outdated Show resolved Hide resolved

mgechev reviewed

View reviewed changes

Owner

mgechev left a comment

Left few minor comments. Would you share details about autofocus considered as a bad practice?

Contributor Author

mohammedzamakhan commented Feb 10, 2019

@mgechev you can find the warning here https://w3c.github.io/html/sec-forms.html#autofocusing-a-form-control-the-autofocus-attribute


          feat(rule): autofocus attribute should not be used

c428fc6

mgechev approved these changes

View reviewed changes

mgechev merged commit 799382f into mgechev:master

rgant commented Jul 31, 2019

Seems like W3C has removed the warning about autofocus now. I don't see anything referencing autofocus in the July 18, 2019 version of the document. I would like to review the discussion if I could find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment