fix(rule): 'NgModule' not being handled properly for contextual-lifecycle and contextual-decorators #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
reviewed
Mar 17, 2019
test/contextualLifecycleRule.spec.ts
Outdated
| @@ -150,6 +150,170 @@ describe(ruleName, () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('failure', () => { | |||
There was a problem hiding this comment.
Suggested change
| describe('failure', () => { |
We already have a failure describe block. You can put the NgModule block into it.
|
Nice catch! ✅ I guess this change also fix the |
…ual-decorators rules
wKoza
force-pushed
the
fix-contextual-lifecycle-rule
branch
from
6c389aa
to
c3847e5
Compare
|
Actually, we kill two birds with one stone. |
rafaelss95
changed the title
|
LGMT! |
mgechev
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.