Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule): detect trackBy function when ngFor spans multiple lines #813

Merged
merged 1 commit into from Apr 22, 2019

Conversation

mattlewis92
Copy link
Contributor

Prettier formats some *ngFor expressions across multiple lines which currently isn't picked up by codelyzer, I'm not sure if there is a tighter way of fixing this rather than just deleting the start of the regexp, but all the tests pass so maybe this is enough 馃槃

@rafaelss95 rafaelss95 self-requested a review April 21, 2019 21:23
Copy link
Collaborator

@rafaelss95 rafaelss95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@wKoza wKoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wKoza wKoza merged commit 2260dfd into mgechev:master Apr 22, 2019
@mattlewis92 mattlewis92 deleted the track-by-multiline-fix branch April 22, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants