Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y errors in console have absolute paths #856

Open
markgoho opened this issue Jul 18, 2019 · 2 comments
Open

a11y errors in console have absolute paths #856

markgoho opened this issue Jul 18, 2019 · 2 comments

Comments

@markgoho
Copy link

Describe the bug
Errors in the console link to absolute paths. We should use relative paths.

Context and configuration

Please share:
a11y rules are what are specifically linking to absolute file paths

To Reproduce
Create a template that violates a rule, one for angular style guide, the other for an a11y rule

Expected behavior
The error would print in the console with a relative file path

Additional context
Here's an error for a style guide rule:

ERROR: C:/Users/Jack/Documents/Rosie/rosie-storefront/libs/storefront/checkout/src/lib/components/address-selector/address-selector.component.ts:5:13 - The selector should be kebab-cased and include a dash (https://angular.io/guide/styleguide#style-05-02)

When that link is ctrl+clicked on in VS Code, here's what the breadcrumbs look like:
image

Here is an a11y error:

ERROR: c:/users/jack/documents/rosie/rosie-storefront/libs/storefront/checkout/src/lib/containers/payment-type/payment-type.component.html:10:4 - click must be accompanied by either keyup, keydown or keypress event for accessibility

and the breadcrumbs in VS Code:
image

The issue that this presents is that VS Code can't "find" the file in the project when it's opened from an absolute path, so it doesn't show up in the sidebar. Kind of annoying.

@mgechev
Copy link
Owner

mgechev commented Jul 18, 2019

@mohammedzamakhan would you have a moment to look at that?

@mohammedzamakhan
Copy link
Contributor

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants