fix(angular): update function call broken by Angular changes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
changed the title
|
@ayazhafiz thanks for the PR! What's the impacted Angular version? |
|
Since 8.2.0, I believe. The impacting commit is angular/angular@f65db20.
…________________________________
From: Minko Gechev <notifications@github.com>
Sent: Thursday, September 19, 2019 9:31 AM
To: mgechev/codelyzer
Cc: hafiz; Mention
Subject: Re: [mgechev/codelyzer] fix(angular): update function call broken by Angular changes (#857)
@ayazhafiz<https://github.com/ayazhafiz> thanks for the PR! What's the impacted Angular version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#857?email_source=notifications&email_token=AE6GL6VIUODZLAATZETQOHLQKOELFA5CNFSM4IE672FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DVQYI#issuecomment-533157985>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AE6GL6WDYQGZWD233JGDT3LQKOELFANCNFSM4IE672FA>.
|
|
@ayazhafiz this should be easy to merge. Would you just bump the |
ayazhafiz
force-pushed
the
fix/parseAction
branch
from
0fdb2dd
to
58da040
Compare
Yep, done :) |
mgechev
approved these changes
Sep 22, 2019
ayazhafiz
force-pushed
the
fix/parseAction
branch
from
58da040
to
dd06d89
Compare
angular/angular#31391 introduces a breaking change to `parseAction`, which now requires at least three parameters. This provides a fix-forward for when the change lands.
ayazhafiz
force-pushed
the
fix/parseAction
branch
from
dd06d89
to
3b356c0
Compare
|
Just updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
angular/angular#31391 introduces a breaking change to
parseAction,which now requires at least three parameters. This provides a
fix-forward for when the change lands.