Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixer should not be added when using custom template transformation without sourcemaps #882

Open
undsoft opened this issue Aug 26, 2019 · 1 comment
Labels

Comments

@undsoft
Copy link

undsoft commented Aug 26, 2019

This relates to me trying to use pug with codelyzer here:
#880

The problem is that I don't have sourcemaps.
When I use tslint --fix, any template rules that have a fixer (I've just tried angular-whitespace) will update the code incorrectly.

I think it would be best if codelyzer didn't attempt to add a fix, if a custom transformTemplate function is used and no sourcemap is provided.

@undsoft undsoft changed the title Fixer should not be added when using custom tempalte transformation without sourcemaps Fixer should not be added when using custom template transformation without sourcemaps Aug 26, 2019
@mgechev mgechev added the bug label Sep 16, 2019
@rafaelss95
Copy link
Collaborator

@undsoft I don't use pug, but angular-whitespace is deprecated and it as far I can remember, it has some problems with its fixer. We have just another template rule that has a fixer, the template-banana-in-box. Would you mind to try to reproduce the problem with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants