-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect unnecessary gomock controller Finish call #940
Comments
Hi @hendrywiranto, thanks for the proposal. IMO the use case addressed by the proposed rule is quite niche. I'm not convinced it fits in the |
Hi @chavacava |
I propose to keep the issue open and see if some other users manifest interest in the rule you propose. Thanks again! |
I see |
Is your feature request related to a problem? Please describe.
As highlighted in https://pkg.go.dev/github.com/golang/mock/gomock#NewController:
Describe the solution you'd like
A linting rule that can flag when we're unnecessarily calling .Finish to gomock controller, when using a Go version of 1.14+.
Describe alternatives you've considered
Submit a new linter to golangci-lint but it seems like 1 linter for this functionality only is overkill
Additional context
Hello, does this linter support checking of a library usage too?
If yes, I would like to open a PR for this
The text was updated successfully, but these errors were encountered: