Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select main color? #57

Open
hagenw opened this issue Sep 15, 2021 · 1 comment
Open

Add option to select main color? #57

hagenw opened this issue Sep 15, 2021 · 1 comment

Comments

@hagenw
Copy link
Contributor

hagenw commented Sep 15, 2021

One first step to tackle #5 could be to add the option to select the main color of the theme.
This seems to me the most important one (maybe folks that use a dark theme disagree with me), as you then can make the theme match the color of your already existing HTML pages or whatever you would like to match.

Looking at the current implementation we use the following colored elements where the color conveys a meaning:

image

image

image

And we have the following colored elements where the color does not convey a meaning:

image

image

image

image

And some gray elements, that I would not count under colored:

image

image


So, the default color of the theme seems to be blue as this is used for links and some boxes.
We could make this changeable, but I guess you selected the blue in a way that it matches the red parts of the theme, which shouldn't change its color as the color conveys meaning.

@mgeier
Copy link
Owner

mgeier commented Sep 15, 2021

I think we should introduce CSS variables for all colors as part of #5.
Then we can have two sets of definitions, one for the light theme and one for the dark.
We just have to come up with meaningful names (probably with a custom prefix).

I've collected a few links in #5, maybe some of them can serve as inspiration?

BTW, there is yet another color: https://insipid-sphinx-theme.readthedocs.io/en/0.2.7/showcase/admonitions.html#topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants