Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding overflow height to bottom #385

Open
SrkaLo92 opened this issue Jan 28, 2022 · 8 comments
Open

Adding overflow height to bottom #385

SrkaLo92 opened this issue Jan 28, 2022 · 8 comments

Comments

@SrkaLo92
Copy link

Hi, thanks for contributing!

This project is maintained in my spare time, so in order to help me address your issue as quickly as
possible, please provide as much of the following information as you can.

-- Michael

[^ delete this message]

=======

**Angular version2.1.4:

**ngx-pagination version5.1.1:

I just implement pagination to my project, and everything works fine, but for some reason there is some height on bottom of pagination-controls. I checked css, and I cannot find solution.

Here is the link of screen record: https://youtu.be/SzxCwi48ozE

@michaelbromley
Copy link
Owner

Hi, I get "video unavailable" at that link.

@SrkaLo92
Copy link
Author

SrkaLo92 commented Jan 31, 2022 via email

@michaelbromley
Copy link
Owner

OK thanks. Can you reproduce it in a StackBlitz demo?

@SrkaLo92
Copy link
Author

SrkaLo92 commented Jan 31, 2022 via email

@michaelbromley
Copy link
Owner

You don't need to provide all your proprietary code. Just a minimal reproduction. If you can isolate the minimum code which will reproduce the issue, I have a much better chance of being able to spot what might be causing it.

@SrkaLo92
Copy link
Author

SrkaLo92 commented Feb 1, 2022 via email

@SrkaLo92
Copy link
Author

SrkaLo92 commented Feb 1, 2022 via email

@michaelbromley
Copy link
Owner

Hi, I'm afraid I don't have time to install, explore and investigate an entire repo of that size. That's why I ask for a minimal reproduction, i.e. the absolute bare minimum code which reproduces the issue. Ideally an app with a single component and no other 3rd party libs (unless they are required to reproduce the issue).

This step - building a minimal reproduction - can take a little bit of time. However, in doing so, quite often you will come to figure out the cause of the issue for yourself. And if not, the hour or so you spend on putting it together represents an equivalent time saving for me. Is my time more valuable than yours? Not necessarily! But in this case, you have more interest in solving the issue than I do, so it makes sense. Doing it any other way makes OSS very burdensome on maintainers.

So again, here's the Stackblitz demo which you can use as a starting point in putting together a minimal reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants