Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fingerprint to be based on path, check_name, and source #56

Open
Ovissse opened this issue Oct 25, 2022 · 2 comments · May be fixed by #57
Open

Change fingerprint to be based on path, check_name, and source #56

Ovissse opened this issue Oct 25, 2022 · 2 comments · May be fixed by #57

Comments

@Ovissse
Copy link

Ovissse commented Oct 25, 2022

Currently noticed, that gitlab reports old code style errors as new. Turns out that if error moved to different line the fingerprint for it changes as well and gitlab treat it as new code style problem. Did some digging and found out that codeclimate computes fingerprint differently. Instead of relaying on line, they read content of that line and strip whitespaces.
Reference to codeclimate fingerpint pr
@Ovissse Ovissse linked a pull request Oct 25, 2022 that will close this issue
Open
@micheh
Copy link
Owner

micheh commented Oct 27, 2022

That is a good catch, thank you. Will GitLab report multiple issues if a code block is used multiple times in a file and has an issue?

@Ovissse
Copy link
Author

Ovissse commented Oct 31, 2022 •
edited

Ok codeclimate solution doesn't work very well then there are multiple same code lines with same code quality issues in the same file. GitLab treats issues with same fingerprint as one.

Example of original problem:

Examples of new problems after fingerprint calculation change:

So fixing one problem opens whole can of more problems. GitLab doesn't behave nicely with issues that have same fingerprint. This will need different fingerprint calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve same fingerprint after issue moved to another line. Ovissse/phpcs-gitlab
2 participants
@micheh @Ovissse