Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query-builder feedback #52

Open
jdtsmith opened this issue Aug 16, 2023 · 2 comments
Open

query-builder feedback #52

jdtsmith opened this issue Aug 16, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jdtsmith
Copy link

jdtsmith commented Aug 16, 2023

Playing with the new query builder: such a powerful tool. It's clear you spent a long while getting the interface just right.

A few things I noticed:

  • I don't know how to quit the query-builder. Just kill the buffer? A q binding on the transient would be nice to quit and clean-up (and maybe prompt to save the query on the query ring).
  • As you experiment, often the positive results of older queries are not erased. I.e. highlighting remains.
  • The completion of types is simply wonderful. Field names for given types also work, but not based on the text in-buffer. I.e. in (dictionary (pair [X]) @hl.silver), with point after the pair , M-Tab gives a list of fields, but entering a fragment of one and completing ((dictionary (pair ke[X]) @hl.silver)) does not.
  • Would be great if @before/@after etc. were presented as capturing completions, in addition to the highlight colors.
  • A binding for M-g p/n to move to the previous/next known error position (if any) would be lovely.

Just started playing; thanks again for this powerful tool.

@mickeynp
Copy link
Owner

Thanks for the great feedback. I'll try and fix them.

@mickeynp mickeynp added bug Something isn't working enhancement New feature or request labels Aug 17, 2023
@aspiers
Copy link

aspiers commented Apr 12, 2024

I also noticed the first two items here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants