Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node 6 end of support to changelog #160

Closed
yvele opened this issue Apr 25, 2019 · 4 comments
Closed

Add node 6 end of support to changelog #160

yvele opened this issue Apr 25, 2019 · 4 comments

Comments

@yvele
Copy link
Contributor

yvele commented Apr 25, 2019

You are now using object destructuring in micromatch v4 and that is not supported in node v6.

That's ok because you explicitly dropped support of node v6 976d956#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

But it looks like you forgot to mention that in the breaking section of the changelog https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md#400---2019-03-20
@jonschlinkert
Copy link
Member

Thanks for pointing it out, would you like to do a PR?

@yvele
Copy link
Contributor Author

yvele commented Apr 25, 2019 •
edited

Sure -> #161

@yvele yvele mentioned this issue Apr 25, 2019
Merged
@nomoon nomoon mentioned this issue May 1, 2019
Merged
@johnnyreilly
Copy link

If this could be added it would be helpful; I published a breaking changes version of ts-loader without meaning to. TypeStrong/ts-loader#929

@mastermatt mastermatt mentioned this issue Jun 25, 2019
Closed
@jonschlinkert
Copy link
Member

@johnnyreilly I'm really sorry that you experienced that. My apologies.

@yvele thanks for the PR and issue!

closed by #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonschlinkert @johnnyreilly @yvele