fix bad text values in parse
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously sibling `text` tokens would exclude the `output` from the first token, resulting in the referenced issues. I think this should be a fairly safe change. Fixes micromatch#125 Fixes micromatch#100
connor4312
commented
Dec 12, 2023
|
|
||
| const expected = [ | ||
| ['bos', { output: '', value: '' }], | ||
| ['text', { output: 'foo.', value: 'foo.' }], |
There was a problem hiding this comment.
This was just a ., which is what issue #100 referenced
connor4312
commented
Dec 12, 2023
| ['bos', { output: '', value: '' }], | ||
| ['text', { output: 'foo.', value: 'foo.' }], | ||
| ['paren', { output: undefined, value: '(' }], | ||
| ['text', { output: 'm|c|', value: 'm|c|' }], |
There was a problem hiding this comment.
This was |c| which is what #125 referenced
|
Sorry for the late reply, and thanks for the PR. Reviewing now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously sibling
texttokens would exclude theoutputfrom the first token, resulting in the referenced issues. I think this should be a fairly safe change.Fixes #125
Fixes #100