Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle Wrapper 7.6 #3547

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Upgrade to Gradle Wrapper 7.6 #3547

merged 1 commit into from
Nov 28, 2022

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 26, 2022

This PR upgrades to Gradle Wrapper 7.6.

@izeye
Copy link
Contributor Author

izeye commented Nov 26, 2022

Builds for this are failing on Circle as follows:

#!/bin/bash -eo pipefail
./gradlew downloadDependencies --console=plain
Downloading https://services.gradle.org/distributions/gradle-7.6-bin.zip
...........10%............20%...........30%............40%............50%...........60%............70%............80%...........90%............100%

Welcome to Gradle 7.6!

Here are the highlights of this release:
 - Added support for Java 19.
 - Introduced `--rerun` flag for individual task rerun.
 - Improved dependency block for test suites to be strongly typed.
 - Added a pluggable system for Java toolchains provisioning.

For more details see https://docs.gradle.org/7.6/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'micrometer'.
> Could not resolve all files for configuration ':classpath'.
   > Did not resolve 'io.spring.nohttp:nohttp-gradle:0.0.10' which is part of the dependency lock state
   > Did not resolve 'com.google.guava:guava:29.0-jre' which is part of the dependency lock state
   > Did not resolve 'org.antlr:antlr4-runtime:4.8-1' which is part of the dependency lock state
   > Did not resolve 'com.google.j2objc:j2objc-annotations:1.3' which is part of the dependency lock state
   > Did not resolve 'org.checkerframework:checker-qual:2.11.1' which is part of the dependency lock state
   > Did not resolve 'ch.qos.logback:logback-core:1.2.3' which is part of the dependency lock state
   > Did not resolve 'com.google.errorprone:error_prone_annotations:2.3.4' which is part of the dependency lock state
   > Did not resolve 'org.ajoberstar.grgit:grgit-core:4.0.2' which is part of the dependency lock state
   > Did not resolve 'com.google.guava:failureaccess:1.0.1' which is part of the dependency lock state
   > Did not resolve 'ch.qos.logback:logback-classic:1.2.3' which is part of the dependency lock state
   > Did not resolve 'io.spring.nohttp:nohttp:0.0.10' which is part of the dependency lock state
   > Did not resolve 'info.picocli:picocli:4.3.1' which is part of the dependency lock state
   > Did not resolve 'commons-beanutils:commons-beanutils:1.9.4' which is part of the dependency lock state
   > Did not resolve 'commons-collections:commons-collections:3.2.2' which is part of the dependency lock state
   > Did not resolve 'net.sf.saxon:Saxon-HE:9.9.1-7' which is part of the dependency lock state
   > Did not resolve 'io.spring.nohttp:nohttp-checkstyle:0.0.10' which is part of the dependency lock state
   > Did not resolve 'antlr:antlr:2.7.7' which is part of the dependency lock state
   > Did not resolve 'com.google.code.findbugs:jsr305:3.0.2' which is part of the dependency lock state
   > Did not resolve 'com.puppycrawl.tools:checkstyle:8.33' which is part of the dependency lock state
   > Did not resolve 'com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava' which is part of the dependency lock state
   > Could not resolve io.spring.nohttp:nohttp-gradle:0.0.10.
     Required by:
         project :
      > Could not resolve io.spring.nohttp:nohttp-gradle:0.0.10.
         > Could not get resource 'https://plugins.gradle.org/m2/io/spring/nohttp/nohttp-gradle/0.0.10/nohttp-gradle-0.0.10.module'.
            > Could not GET 'https://jcenter.bintray.com/io/spring/nohttp/nohttp-gradle/0.0.10/nohttp-gradle-0.0.10.module'.
               > PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
   > Could not resolve io.spring.nohttp:nohttp-gradle:0.0.10.
     Required by:
         project :
      > Could not resolve io.spring.nohttp:nohttp-gradle:0.0.10.
         > Could not get resource 'https://plugins.gradle.org/m2/io/spring/nohttp/nohttp-gradle/0.0.10/nohttp-gradle-0.0.10.module'.
            > Could not GET 'https://jcenter.bintray.com/io/spring/nohttp/nohttp-gradle/0.0.10/nohttp-gradle-0.0.10.module'.
               > PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
   > Could not resolve org.ajoberstar.grgit:grgit-core:4.0.2.
     Required by:
         project :
      > Could not resolve org.ajoberstar.grgit:grgit-core:4.0.2.
         > Could not get resource 'https://plugins.gradle.org/m2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom'.
            > Could not GET 'https://jcenter.bintray.com/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom'.
               > PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
   > Could not resolve org.ajoberstar.grgit:grgit-core:4.0.2.
     Required by:
         project : > com.netflix.nebula:nebula-release-plugin:16.1.0
      > Could not resolve org.ajoberstar.grgit:grgit-core:4.0.2.
         > Could not get resource 'https://plugins.gradle.org/m2/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom'.
            > Could not GET 'https://jcenter.bintray.com/org/ajoberstar/grgit/grgit-core/4.0.2/grgit-core-4.0.2.pom'.
               > PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 13s

A build scan was not published as you have not authenticated with server 'ge.micrometer.io'.
For more information, please see https://gradle.com/help/gradle-authenticating-with-gradle-enterprise.

Exited with code exit status 1
CircleCI received exit code 1

The certificate for "jcenter.bintray.com" seems to have been expired yesterday as follows:

% openssl s_client -connect jcenter.bintray.com:443 | openssl x509 -noout -dates 
depth=2 C = US, O = DigiCert Inc, OU = www.digicert.com, CN = DigiCert Global Root CA
verify return:1
depth=1 C = US, O = DigiCert Inc, CN = GeoTrust TLS DV RSA Mixed SHA256 2020 CA-1
verify return:1
depth=0 CN = *.bintray.com
verify error:num=10:certificate has expired
notAfter=Nov 25 23:59:59 2022 GMT
verify return:1
depth=0 CN = *.bintray.com
notAfter=Nov 25 23:59:59 2022 GMT
verify return:1
notBefore=Oct 25 00:00:00 2021 GMT
notAfter=Nov 25 23:59:59 2022 GMT

Somehow running the same command locally is working as follows:

% ./gradlew downloadDependencies --console=plain    

> Configure project :
Inferred project: micrometer, version: 1.9.0-SNAPSHOT
I'm configuring micrometer with version 1.9.0-SNAPSHOT

> Configure project :micrometer-benchmarks-core
I'm configuring micrometer-benchmarks-core with version 1.9.0-SNAPSHOT

> Configure project :micrometer-bom
I'm configuring micrometer-bom with version 1.9.0-SNAPSHOT

> Configure project :micrometer-core
I'm configuring micrometer-core with version 1.9.0-SNAPSHOT

> Configure project :micrometer-jersey2
I'm configuring micrometer-jersey2 with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-appoptics
I'm configuring micrometer-registry-appoptics with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-atlas
I'm configuring micrometer-registry-atlas with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-azure-monitor
I'm configuring micrometer-registry-azure-monitor with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-cloudwatch
I'm configuring micrometer-registry-cloudwatch with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-cloudwatch2
I'm configuring micrometer-registry-cloudwatch2 with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-datadog
I'm configuring micrometer-registry-datadog with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-dynatrace
I'm configuring micrometer-registry-dynatrace with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-elastic
I'm configuring micrometer-registry-elastic with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-ganglia
I'm configuring micrometer-registry-ganglia with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-graphite
I'm configuring micrometer-registry-graphite with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-health
I'm configuring micrometer-registry-health with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-humio
I'm configuring micrometer-registry-humio with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-influx
I'm configuring micrometer-registry-influx with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-jmx
I'm configuring micrometer-registry-jmx with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-kairos
I'm configuring micrometer-registry-kairos with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-new-relic
I'm configuring micrometer-registry-new-relic with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-opentsdb
I'm configuring micrometer-registry-opentsdb with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-prometheus
I'm configuring micrometer-registry-prometheus with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-signalfx
I'm configuring micrometer-registry-signalfx with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-stackdriver
I'm configuring micrometer-registry-stackdriver with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-statsd
I'm configuring micrometer-registry-statsd with version 1.9.0-SNAPSHOT

> Configure project :micrometer-registry-wavefront
I'm configuring micrometer-registry-wavefront with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-boot2
I'm configuring micrometer-samples-boot2 with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-boot2-reactive
I'm configuring micrometer-samples-boot2-reactive with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-core
I'm configuring micrometer-samples-core with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-hazelcast
I'm configuring micrometer-samples-hazelcast with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-hazelcast3
I'm configuring micrometer-samples-hazelcast3 with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-javalin
I'm configuring micrometer-samples-javalin with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-jersey3
I'm configuring micrometer-samples-jersey3 with version 1.9.0-SNAPSHOT

> Configure project :micrometer-samples-spring-integration
I'm configuring micrometer-samples-spring-integration with version 1.9.0-SNAPSHOT

> Configure project :micrometer-test
I'm configuring micrometer-test with version 1.9.0-SNAPSHOT

> Task :micrometer-bom:downloadDependencies
> Task :micrometer-benchmarks-core:downloadDependencies
> Task :micrometer-registry-cloudwatch:downloadDependencies
> Task :micrometer-registry-atlas:downloadDependencies
> Task :micrometer-registry-azure-monitor:downloadDependencies
> Task :micrometer-registry-appoptics:downloadDependencies
> Task :micrometer-registry-datadog:downloadDependencies
> Task :micrometer-registry-dynatrace:downloadDependencies
> Task :micrometer-registry-humio:downloadDependencies
> Task :micrometer-registry-health:downloadDependencies
> Task :micrometer-registry-influx:downloadDependencies
> Task :micrometer-registry-jmx:downloadDependencies
> Task :micrometer-registry-ganglia:downloadDependencies
> Task :micrometer-registry-opentsdb:downloadDependencies
> Task :micrometer-jersey2:downloadDependencies
> Task :micrometer-registry-kairos:downloadDependencies
> Task :micrometer-registry-new-relic:downloadDependencies
> Task :micrometer-registry-prometheus:downloadDependencies
> Task :micrometer-registry-cloudwatch2:downloadDependencies
> Task :micrometer-registry-wavefront:downloadDependencies
> Task :micrometer-registry-elastic:downloadDependencies
> Task :micrometer-registry-statsd:downloadDependencies
> Task :micrometer-samples-hazelcast3:downloadDependencies
> Task :micrometer-samples-javalin:downloadDependencies
> Task :micrometer-registry-stackdriver:downloadDependencies
> Task :micrometer-samples-jersey3:downloadDependencies
> Task :micrometer-test:downloadDependencies
> Task :micrometer-samples-spring-integration:downloadDependencies
> Task :micrometer-samples-boot2-reactive:downloadDependencies
> Task :micrometer-samples-hazelcast:downloadDependencies
> Task :micrometer-registry-signalfx:downloadDependencies
> Task :micrometer-core:downloadDependencies
> Task :micrometer-registry-graphite:downloadDependencies
> Task :micrometer-samples-core:downloadDependencies
> Task :micrometer-samples-boot2:downloadDependencies

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2s
35 actionable tasks: 35 executed

A build scan was not published as you have not authenticated with server 'ge.micrometer.io'.
For more information, please see https://gradle.com/help/gradle-authenticating-with-gradle-enterprise.
%

@shakuzen
Copy link
Member

It looks like the expired certificate issue has been resolved. Could you rerun the CircleCI build?

@izeye
Copy link
Contributor Author

izeye commented Nov 27, 2022

@shakuzen Sure, done!

@shakuzen shakuzen added build A change in our build-system dependency-upgrade A dependency upgrade labels Nov 28, 2022
@shakuzen shakuzen added this to the 1.8.13 milestone Nov 28, 2022
@shakuzen shakuzen merged commit 0c9568a into micrometer-metrics:1.8.x Nov 28, 2022
shakuzen added a commit that referenced this pull request Nov 28, 2022
@shakuzen
Revert "Upgrade to Gradle Wrapper 7.6 (#3547)"
1cd3390 
This reverts commit 0c9568a.
shakuzen added a commit that referenced this pull request Nov 29, 2022
@shakuzen
Revert "Upgrade to Gradle Wrapper 7.6 (#3547)"
6b5bb4c 
This reverts commit 0c9568a.

Resolves gh-3553
@izeye izeye deleted the gradle-wrapper-7.6 branch December 2, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build A change in our build-system dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
1.8.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @shakuzen