Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @since tags across the code base where appropriate #3907

Closed
sbrannen opened this issue Jun 14, 2023 · 2 comments
Closed

Add missing @since tags across the code base where appropriate #3907

sbrannen opened this issue Jun 14, 2023 · 2 comments
Labels
doc-update A documentation update
Milestone

Comments

@sbrannen
Copy link

Overview

I unfortunately don't have time to determine all locations where @since tags are missing within the code base, but I have noticed that features have recently been added without @since tags.

For example, the new getObservationRegistry() and setObservationRegistry(...) methods were added in 1.10.8, but the class-level Javadoc for ObservationThreadLocalAccessor makes it appear that these methods have existed since 1.10.0, which is not true.

Related Issues

@sbrannen
Copy link
Author

At a glance, it appears that several constructors and methods in ObservationThreadLocalAccessor were introduced in 1.10.8 without @since tags.

@marcingrzejszczak
Copy link
Contributor

Yup, will fix that ASAP

@marcingrzejszczak marcingrzejszczak added doc-update A documentation update and removed waiting-for-triage labels Jun 14, 2023
@marcingrzejszczak marcingrzejszczak added this to the 1.10.9 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-update A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants