Add eviction/removal listeners #401
Merged
+175
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matteocastellotti
force-pushed
the
master
branch
from
e559cd4 to
6462448
Compare
…icronaut-projects#400) Bumps [io.micronaut.build.shared.settings](https://github.com/micronaut-projects/micronaut-build) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/micronaut-projects/micronaut-build/releases) - [Commits](micronaut-projects/micronaut-build@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: io.micronaut.build.shared.settings dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [spock](https://github.com/testcontainers/testcontainers-java) from 1.16.2 to 1.16.3. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.16.2...1.16.3) --- updated-dependencies: - dependency-name: org.testcontainers:spock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…cronaut-projects#403) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3.12.0 to 3.12.1. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v3.12.0...v3.12.1) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ut-projects#407) Bumps [mikepenz/action-junit-report](https://github.com/mikepenz/action-junit-report) from 2.9.0 to 2.9.1. - [Release notes](https://github.com/mikepenz/action-junit-report/releases) - [Commits](mikepenz/action-junit-report@v2.9.0...v2.9.1) --- updated-dependencies: - dependency-name: mikepenz/action-junit-report dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* use Gradle 7.4 * cleanup * use Micronaut 3.3.1 * make cache-tck a module so it gets published
|
@matteocastellotti thanks for your contribution! Could you please add a note at https://github.com/micronaut-projects/micronaut-cache/blob/master/src/main/docs/guide/cache-abstraction.adoc mentioning that this is possible? Otherwise, this would go unnoticed. |
|
Thanks for considering contributing, but I am not sure this implementation makes sense as written:
|
ludovicc
suggested changes
Feb 14, 2022
| caches: | ||
| my-cache: | ||
| listen-to-removals: true | ||
| listen-to-evictions: true |
There was a problem hiding this comment.
How do you configure a new listener? If there are more than one cache, each needing a different listener, how do you configure that?
|
@graemerocher I added a new configuration layer for the parameters related to caffeine cache and the test to verify that the implementation works |
|
There are some Checkstyle failures |
graemerocher
requested changes
Feb 16, 2022
...feine/src/main/java/io/micronaut/cache/caffeine/configuration/DefaultCacheConfiguration.java
Outdated
Show resolved
Hide resolved
cache-caffeine/src/main/java/io/micronaut/cache/caffeine/DefaultSyncCache.java
Outdated
Show resolved
Hide resolved
cache-caffeine/src/main/java/io/micronaut/cache/caffeine/DefaultSyncCache.java
Outdated
Show resolved
Hide resolved
graemerocher
approved these changes
Feb 21, 2022
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to add an eviction/removal listener when configuring the cache