the netty unicast processor is not emitting errors for downstream subscribers #6074
Conversation
|
Needs a test |
| emitter.error(t); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doOnComplete() { | ||
| for (UnicastProcessor subject : subjects.values()) { | ||
| subjects.values().forEach(subject -> { |
There was a problem hiding this comment.
Don't change to functional style
There was a problem hiding this comment.
Sorry about that, force of habit
| @@ -827,16 +827,17 @@ protected void doOnNext(Object message) { | |||
| @Override | |||
| protected void doOnError(Throwable t) { | |||
| s.cancel(); | |||
| subjects.values().forEach(subject -> subject.onError(t)); | |||
There was a problem hiding this comment.
A simple for loop as is below is preferred here
|
This will sound crazy but I can't replicate the kotlin failure via a test (see here: https://github.com/rawilder/mn-multi-file-upload/pull/1/files). It's only happening via server start -> manual request. Which means I'd have to inject a failure somehow into the onNext function of |
|
@rawilder Try moving the test which should fail into its own class. Because tests are executing before the new tests they are not the first request to the server which is the case where we saw the failure |
|
@jameskleeh I moved the two tests to their own class locally and both succeeded. Would you like me to still push that to separate them out? |
related to: #6062